[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#928090: unblock: ipywidgets/6.0.0-4



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi there,

I'd like to request the unblock of ipywidgets, please.  The current
package in buster FTBFS due to a small JavaScript issue (RC bug #926802)
in the build system of the package..  The patch below fixes the problem;
I'm a member of the Python team, and can upload the fix if
approved/needed.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

diff --git a/debian/changelog b/debian/changelog
index e19e631..0ab3d10 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+ipywidgets (6.0.0-4) unstable; urgency=medium
+
+  * Team upload.
+  * Use 'Object.prototype' instead of 'path.scope.getBindings' when
+    calling 'hasOwnProperty'.  (Closes: #926802)
+
+ -- Sergio Durigan Junior <sergiodj@debian.org>  Sat, 27 Apr 2019 15:18:56 -0400
+
 ipywidgets (6.0.0-3) unstable; urgency=medium
 
   [ Ondřej Nový ]
diff --git a/debian/fakewebpack-postprocess.js b/debian/fakewebpack-postprocess.js
index e7f7dbc..8126eef 100755
--- a/debian/fakewebpack-postprocess.js
+++ b/debian/fakewebpack-postprocess.js
@@ -127,7 +127,7 @@ var transform = function transform(ast, fn, moduleList) {
               && injectGlobalsReplace.hasOwnProperty(path.node.name)
               && (parent.type !== 'MemberExpression' || parent.object === path.node)
               && (parent.type !== 'Property' || parent.value === path.node)) {
-                if (!path.scope.getBindings().hasOwnProperty(path.node.name)) {
+                if (!Object.prototype.hasOwnProperty.call(path.scope.getBindings(), path.node.name)) {
                     injectGlobals.push(path.node.name);
                 }
             }

Attachment: signature.asc
Description: PGP signature


Reply to: