[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#925559: marked as done (unblock: netlib-java/0.9.3-5)

Your message dated Wed, 27 Mar 2019 20:59:00 +0000
with message-id <5e2b63d3-4bb1-e631-11bc-4ca25f84aab0@thykier.net>
and subject line Re: Bug#925559: unblock: netlib-java/0.9.3-5
has caused the Debian Bug report #925559,
regarding unblock: netlib-java/0.9.3-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
925559: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925559
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package netlib-java


diff -Nru netlib-java-0.9.3/debian/changelog netlib-java-0.9.3/debian/changelog
--- netlib-java-0.9.3/debian/changelog	2019-01-13 21:11:05.000000000 +0100
+++ netlib-java-0.9.3/debian/changelog	2019-03-26 16:47:32.000000000 +0100
@@ -1,3 +1,10 @@
+netlib-java (0.9.3-5) unstable; urgency=medium
+
+  * Fix URLClassLoader
+    Closes: #923759
+
+ -- Andreas Tille <tille@debian.org>  Tue, 26 Mar 2019 16:47:32 +0100
+
 netlib-java (0.9.3-4) unstable; urgency=medium
 
   * Deactivate watch file since in debian/README.source is declared that
diff -Nru netlib-java-0.9.3/debian/patches/series netlib-java-0.9.3/debian/patches/series
--- netlib-java-0.9.3/debian/patches/series	2019-01-13 21:11:05.000000000 +0100
+++ netlib-java-0.9.3/debian/patches/series	2019-03-26 16:47:32.000000000 +0100
@@ -1 +1,2 @@
 update_classpath.patch
+URLClassLoader.patch
diff -Nru netlib-java-0.9.3/debian/patches/URLClassLoader.patch netlib-java-0.9.3/debian/patches/URLClassLoader.patch
--- netlib-java-0.9.3/debian/patches/URLClassLoader.patch	1970-01-01 01:00:00.000000000 +0100
+++ netlib-java-0.9.3/debian/patches/URLClassLoader.patch	2019-03-26 16:47:32.000000000 +0100
@@ -0,0 +1,48 @@
+From: Markus Koschany <apo@debian.org>
+Date: Mon, 25 Mar 2019 14:44:22 +0100
+Bug-Debian: https://bugs.debian.org/923759
+Subject: URLClassLoader
+
+---
+ src/org/netlib/generate/JavaGenerator.java | 14 ++++++++++++--
+ 1 file changed, 12 insertions(+), 2 deletions(-)
+
+diff --git a/src/org/netlib/generate/JavaGenerator.java b/src/org/netlib/generate/JavaGenerator.java
+index fda8e9d..15815de 100644
+--- a/src/org/netlib/generate/JavaGenerator.java
++++ b/src/org/netlib/generate/JavaGenerator.java
+@@ -51,6 +51,8 @@ import org.netlib.util.doubleW;
+ import org.netlib.util.floatW;
+ import org.netlib.util.intW;
+ 
++import java.net.MalformedURLException;
++
+ /**
+  * Due to the depressing number of LAPACK routines, it is much more efficient to
+  * auto-generate the Java code for the wrapper and corresponding Java and JNI
+@@ -643,7 +645,8 @@ class JavaGenerator {
+ 	 * @return all classes in a given package
+ 	 * @see http://forum.java.sun.com/thread.jspa?threadID=757391&messageID=4326850
+ 	 */
+-	private List<Class<?>> getClasses(String packageName, IClassFilter filter) {
++	private List<Class<?>> getClasses(String packageName, IClassFilter filter)
++		throws MalformedURLException{
+ 		String packagePath = packageName.replace('.', '/');
+ //		ArrayList<URL> classpath = new ArrayList<URL>();
+ //		String[] classpathString = System.getProperty("java.class.path").split(":");
+@@ -658,7 +661,14 @@ class JavaGenerator {
+ //					log(Level.SEVERE, classpathString[i] + " " + ex.getMessage());
+ //			}
+ //		}
+-		URL [] classpath = ((URLClassLoader) ClassLoader.getSystemClassLoader()).getURLs();
++		URL url1 = new URL("file:///usr/share/java/junit-3.8.2.jar");
++		URL url2 = new URL("file:///usr/share/java/f2jutil-0.8.1.jar");
++		URL url3 = new URL("file:///usr/share/java/jlapack-blas-0.8.jar");
++		URL url4 = new URL("file:///usr/share/java/jlapack-lapack-0.8.jar");
++		URL url5 = new URL("file:///usr/share/java/jlapack-xerbla-0.8.jar");
++		URL url6 = new URL("file:///build/netlib-java-0.9.3/build/classes/");
++
++		URL [] classpath = { url1, url2, url3, url4, url5, url6 };
+ 		List<Class<?>> result = new ArrayList<Class<?>>();
+ 		System.out.println(Arrays.toString(classpath));
+ 		for (URL url : classpath) {


unblock netlib-java/0.9.3-5

-- System Information:
Debian Release: 9.8
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-6-amd64 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message --- 
Andreas Tille:
> Control: tags -1 - moreinfo
> 
> On Wed, Mar 27, 2019 at 06:32:00AM +0000, Niels Thykier wrote:
>>> ++		URL url5 = new URL("file:///usr/share/java/jlapack-xerbla-0.8.jar");
>>> ++		URL url6 = new URL("file:///build/netlib-java-0.9.3/build/classes/");
>>                                            ^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> Is this redundant or required for building the package.  If it is the
>> latter, then sadly we cannot rely on the build-path to be stable, so we
>> will need a better fix (e.g. sbuild and pbuilder does not agree on the
>> paths AFAIR and even if they did, I would probably still prefer a better
>> fix).
> 
> Since it turned out that I got an identical result by simply droping
> that URL I just removed it.  Here is a full debdiff between the version
> in testing and my latest upload (netlib-java_0.9.3-6):
> 
> [...]
> 
> Kind regards
> 
>        Andreas.
> 

Thanks for verifying that. :)

I have unblocked the new version.

Thanks,
~Niels

--- End Message ---
Reply to: