[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#923864: marked as done (unblock: rails/2:5.2.2+dfsg-6)

Your message dated Fri, 15 Mar 2019 20:38:21 +0100
with message-id <bf02c3e9-e2d4-8c20-9c2f-44622a86b2e2@debian.org>
and subject line Re: unblock: rails/2:5.2.2+dfsg-6
has caused the Debian Bug report #923864,
regarding unblock: rails/2:5.2.2+dfsg-6
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
923864: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923864
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package rails

This upload removes packages useful only for rails development from ruby-rails
binary to rails metapackage. This significantly reduces the number of unneeded
packages installed on production systems. The situation was agravated by rails
5 which added ruby-chromedriver-help which pulls in chromium.

It also fixes bundling of active_storage.js. This requires unblocking of
ruby-handlebars-assets as well which was wrongly depending on ruby-rails instead
of rails.

Including the debdiff here:

$ debdiff rails_5.2.2+dfsg-5.dsc rails_5.2.2+dfsg-6.dsc 
dpkg-source: warning: extracting unsigned source package (/home/pravi/forge/debian/git/ruby-team/rails_5.2.2+dfsg-5.dsc)
dpkg-source: warning: extracting unsigned source package (/home/pravi/forge/debian/git/ruby-team/rails_5.2.2+dfsg-6.dsc)
diff -Nru rails-5.2.2+dfsg/debian/changelog rails-5.2.2+dfsg/debian/changelog
--- rails-5.2.2+dfsg/debian/changelog	2019-02-08 16:22:07.000000000 +0530
+++ rails-5.2.2+dfsg/debian/changelog	2019-03-01 19:50:07.000000000 +0530
@@ -1,3 +1,17 @@
+rails (2:5.2.2+dfsg-6) unstable; urgency=medium
+
+  [ Antonio Terceiro ]
+  * debian/tests/control: remove explicit call to gem2deb-test-runner, as it
+    will be added automatically by autodep8.
+
+  [ Pirate Praveen ]
+  * Move all Recommends from ruby-rails to rails as Depends (Closes: #923507)
+  * Drop obsolete Breaks + Replaces rails3
+  * Drop needs-recommends restriction in newapp autopkgtest
+  * Add debian/node_modules path in activestorage/rollup.config.js for spark-md5
+
+ -- Pirate Praveen <praveen@debian.org>  Fri, 01 Mar 2019 19:50:07 +0530
+
 rails (2:5.2.2+dfsg-5) unstable; urgency=medium
 
   * Recommend ruby-chromedriver-helper in ruby-rails
diff -Nru rails-5.2.2+dfsg/debian/control rails-5.2.2+dfsg/debian/control
--- rails-5.2.2+dfsg/debian/control	2019-02-08 16:22:07.000000000 +0530
+++ rails-5.2.2+dfsg/debian/control	2019-03-01 19:50:07.000000000 +0530
@@ -266,27 +266,6 @@
          ruby-sprockets-rails (>= 2.3.2~),
          ${misc:Depends},
          ${shlibs:Depends}
-Recommends: puma (>= 3.11),
-            ruby-bootsnap (>= 1.1.0),
-            ruby-byebug,
-            ruby-chromedriver-helper,
-            ruby-coffee-rails (>= 4.2),
-            ruby-capybara (>= 2.15),
-            ruby-capybara (<< 4.0),
-            ruby-jbuilder (>= 2.5),
-            ruby-jbuilder (<< 3.0),
-            ruby-jquery-rails,
-            ruby-listen (>= 3.0.5),
-            ruby-listen (<< 3.2),
-            ruby-sass-rails (>= 5.0),
-            ruby-sdoc,
-            ruby-selenium-webdriver,
-            ruby-spring,
-            ruby-spring-watcher-listen,
-            ruby-sqlite3,
-            ruby-turbolinks (>= 5.0),
-            ruby-uglifier (>= 1.3.0),
-            ruby-web-console
 Description: MVC ruby based framework geared for web application development
  Rails is a full-stack, open-source web framework in Ruby for writing
  real-world applications.
@@ -299,9 +278,28 @@
 Package: rails
 Architecture: all
 Depends: ruby-rails (= ${source:Version}),
+         puma (>= 3.11),
+         ruby-bootsnap (>= 1.1.0),
+         ruby-byebug,
+         ruby-chromedriver-helper,
+         ruby-coffee-rails (>= 4.2),
+         ruby-capybara (>= 2.15),
+         ruby-capybara (<< 4.0),
+         ruby-jbuilder (>= 2.5),
+         ruby-jbuilder (<< 3.0),
+         ruby-jquery-rails,
+         ruby-listen (>= 3.0.5),
+         ruby-listen (<< 3.2),
+         ruby-sass-rails (>= 5.0),
+         ruby-sdoc,
+         ruby-selenium-webdriver,
+         ruby-spring,
+         ruby-spring-watcher-listen,
+         ruby-sqlite3,
+         ruby-turbolinks (>= 5.0),
+         ruby-uglifier (>= 1.3.0),
+         ruby-web-console,
          ${misc:Depends}
-Replaces: rails3
-Breaks: rails3
 Description: MVC ruby based framework geared for web application development (metapackage)
  Rails is a full-stack, open-source web framework in Ruby for writing
  real-world applications.
diff -Nru rails-5.2.2+dfsg/debian/patches/0002-disable-uglify-in-activestorage-rollup-config-js.patch rails-5.2.2+dfsg/debian/patches/0002-disable-uglify-in-activestorage-rollup-config-js.patch
--- rails-5.2.2+dfsg/debian/patches/0002-disable-uglify-in-activestorage-rollup-config-js.patch	2019-02-08 16:22:07.000000000 +0530
+++ rails-5.2.2+dfsg/debian/patches/0002-disable-uglify-in-activestorage-rollup-config-js.patch	2019-03-01 19:50:07.000000000 +0530
@@ -22,9 +22,16 @@
  
  export default {
    input: "app/javascript/activestorage/index.js",
-@@ -22,7 +22,7 @@
+@@ -20,9 +20,13 @@
+     name: "ActiveStorage"
+   },
    plugins: [
-     resolve(),
+-    resolve(),
++    resolve({
++    customResolveOptions: {
++      moduleDirectory: ['/usr/lib/nodejs','../debian/node_modules']
++    }
++  }),
      commonjs(),
 -    babel(),
 -    uglify(uglifyOptions)
diff -Nru rails-5.2.2+dfsg/debian/tests/control rails-5.2.2+dfsg/debian/tests/control
--- rails-5.2.2+dfsg/debian/tests/control	2019-02-08 16:22:07.000000000 +0530
+++ rails-5.2.2+dfsg/debian/tests/control	2019-03-01 19:50:07.000000000 +0530
@@ -1,5 +1,2 @@
 Tests: newapp
-Restrictions: allow-stderr, needs-recommends
-
-Test-Command: gem2deb-test-runner --autopkgtest --check-dependencies 2>&1
-Depends: @, @builddeps@, gem2deb-test-runner
+Restrictions: allow-stderr

unblock rails/2:5.2.2+dfsg-6

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.18.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_IN, LC_CTYPE=en_IN (charmap=UTF-8), LANGUAGE=en_IN:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--- End Message ---
--- Begin Message --- 
On Wed, 06 Mar 2019 13:30:04 +0100 Pirate Praveen <praveen@debian.org>
wrote:
> Please unblock package rails

unblocked.

Paul

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: