Hi, On 12/01/17 14:54, Lisandro Damián Nicanor Pérez Meyer wrote: > I would like to point out that it would be preferable if, in case a patch is > preferable over going back to the last know version to work, either Matthias > or a mips porter points out which of the two proposed patches is preferable. > > For the time being I'm testing the patch I submited to the bug, but I have no > preference over any of them (nor technical grounds to discuss). Both patches posted in the upstream bug should work. The first one fixes a bug in the MIPS back end so that local symbols are sorted before global symbols. This is probably the safer (although larger) patch because it only touches the MIPS back end to try and bring it into line with other architectures. The second patch prevents the questionable local symbols from every appearing (so no sorting is necessary). This should also be correct, although it will visibly change the contents of the dynamic symbol table on all arches so I am slightly more apprehensive because of that. Side note: the patch you uploaded is not totally correct because it isn't applied when building cross binutils (__mips__ will not be defined there). Thanks, James
Attachment:
signature.asc
Description: OpenPGP digital signature