[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#863725: marked as done (unblock: autodep8/0.9)

Your message dated Wed, 31 May 2017 13:43:56 -0300
with message-id <20170531164356.m4yozvitohccafve@debian.org>
and subject line Re: Bug#863725: unblock: autodep8/0.9
has caused the Debian Bug report #863725,
regarding unblock: autodep8/0.9
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
863725: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863725
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package autodep8

This release adds support for Go packages, but otherwise contains no
changes to the existing functionality. I know this is not exactly the
kind of thing we want during the freeze, but autodep8 is part of the CI
infrastructure, and it will be really useful to have this version in
stretch (as well as in jessie-backports).

debdiff attached

unblock autodep8/0.9

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (500, 'testing'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru autodep8-0.8/debian/changelog autodep8-0.9/debian/changelog
--- autodep8-0.8/debian/changelog	2016-08-25 20:36:02.000000000 -0300
+++ autodep8-0.9/debian/changelog	2017-05-26 07:42:20.000000000 -0300
@@ -1,3 +1,10 @@
+autodep8 (0.9) unstable; urgency=medium
+
+  [ Martín Ferrari ]
+  * Add support for Go package testsuites run by dh_golang_autopkgtest.
+
+ -- Antonio Terceiro <terceiro@debian.org>  Fri, 26 May 2017 07:42:20 -0300
+
 autodep8 (0.8) unstable; urgency=medium
 
   [ Sean Whitton ]
diff -Nru autodep8-0.8/examples.in autodep8-0.9/examples.in
--- autodep8-0.8/examples.in	2016-08-25 20:36:02.000000000 -0300
+++ autodep8-0.9/examples.in	2017-05-26 07:42:20.000000000 -0300
@@ -2,6 +2,7 @@
 # ----  ---------------
 dkms    kpatch
 elpa    flycheck
+go      prometheus
 nodejs  node-tar
 perl    libtest-most-perl
 python  python-flaky
diff -Nru autodep8-0.8/examples.md autodep8-0.9/examples.md
--- autodep8-0.8/examples.md	2016-08-25 20:36:02.000000000 -0300
+++ autodep8-0.9/examples.md	2017-05-26 07:42:20.000000000 -0300
@@ -11,6 +11,12 @@
     Depends: @, @builddeps@
     Restrictions: rw-build-tree
 
+## go (prometheus)
+
+    Test-Command: /usr/bin/dh_golang_autopkgtest
+    Depends: @builddeps@, dh-golang
+    Restrictions: rw-build-tree, allow-stderr
+
 ## nodejs (node-tar)
 
     Test-Command: cd $ADTTMP && nodejs -e "require('"'"'tar'"'"');"
diff -Nru autodep8-0.8/support/go/detect autodep8-0.9/support/go/detect
--- autodep8-0.8/support/go/detect	1969-12-31 21:00:00.000000000 -0300
+++ autodep8-0.9/support/go/detect	2017-05-26 07:42:20.000000000 -0300
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+grep-dctrl --quiet -FBuild-Depends,Build-Depends-Indep,Depends \
+    -e '(^|\s|,)golang-(go|any)($|\s|,)' debian/control
diff -Nru autodep8-0.8/support/go/generate autodep8-0.9/support/go/generate
--- autodep8-0.8/support/go/generate	1969-12-31 21:00:00.000000000 -0300
+++ autodep8-0.9/support/go/generate	2017-05-26 07:42:20.000000000 -0300
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+# Stderr is required because many go tools output status info to stderr.
+cat <<EOF
+Test-Command: /usr/bin/dh_golang_autopkgtest
+Depends: @, @builddeps@, dh-golang
+Restrictions: allow-stderr
+EOF
diff -Nru autodep8-0.8/test/go_test.sh autodep8-0.9/test/go_test.sh
--- autodep8-0.8/test/go_test.sh	1969-12-31 21:00:00.000000000 -0300
+++ autodep8-0.9/test/go_test.sh	2017-05-26 07:42:20.000000000 -0300
@@ -0,0 +1,56 @@
+. $(dirname $0)/helper.sh
+
+test_Testsuite_autopkgtest_pkg_go() {
+  has debian/control 'Testsuite: autopkgtest-pkg-go'
+  check_run autodep8
+}
+
+test_XS_Testsuite_autopkgtest_pkg_go() {
+  has debian/control 'XS-Testsuite: autopkgtest-pkg-go'
+  check_run autodep8
+}
+
+test_detect_bdepends_golang_go() {
+  has 'debian/control' 'Build-Depends: golang-go'
+  check_run autodep8
+}
+
+test_detect_bdepends_golang_any() {
+  has 'debian/control' 'Build-Depends: golang-any'
+  check_run autodep8
+}
+
+test_detect_bdepends_complex() {
+  has 'debian/control' \
+      'Build-Depends: golang-any (>= 2:1.4) || golang-go (>= 2:1.4)'
+  check_run autodep8
+}
+
+test_detect_bdepends_nomatch() {
+  has 'debian/control' 'Build-Depends: golang-goNOPE'
+  run autodep8
+  assertEquals 1 "$exitstatus"
+  assertEquals "" "$(cat stdout stderr)"
+}
+
+test_detect_depends_golang_go() {
+  has 'debian/control' 'Depends: golang-go'
+  check_run autodep8
+}
+
+test_detect_depends_golang_any() {
+  has 'debian/control' 'Depends: golang-any'
+  check_run autodep8
+}
+
+test_detect_bdependsi_golang_go() {
+  has 'debian/control' 'Build-Depends-Indep: golang-go'
+  check_run autodep8
+}
+
+test_detect_bdependsi_golang_any() {
+  has 'debian/control' 'Build-Depends-Indep: golang-any'
+  check_run autodep8
+}
+
+. shunit2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
On Tue, May 30, 2017 at 08:54:29PM +0100, Jonathan Wiltshire wrote:
> Control: tag -1 moreinfo
> 
> Hi,
> 
> On Tue, May 30, 2017 at 11:01:40AM -0300, Antonio Terceiro wrote:
> > This release adds support for Go packages, but otherwise contains no
> > changes to the existing functionality. I know this is not exactly the
> > kind of thing we want during the freeze, but autodep8 is part of the CI
> > infrastructure, and it will be really useful to have this version in
> > stretch (as well as in jessie-backports).
> 
> I'm quite reluctant this late in the process (a couple of weeks ago I
> wouldn't have minded so much). Is this not a good candidate for
> stretch-backports when it opens?

"when it opens" is the key. Until then, I have to provide binaries for
the CI infrastructure by hand. OTOH the last thing I want is to disturb
the release and the release team, so let's forget about this.

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: