[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#862833: marked as done (unblock: haproxy/1.7.5-2)



Your message dated Wed, 17 May 2017 19:57:00 +0000
with message-id <09a25c55-f3a9-6a49-592f-e19ab63f1eb3@thykier.net>
and subject line Re: Bug#862833: unblock: haproxy/1.7.5-2
has caused the Debian Bug report #862833,
regarding unblock: haproxy/1.7.5-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
862833: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862833
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear Release Team,

Please unblock package haproxy.

The version in unstable enables the use of getaddrinfo() (instead of 
gethostbyname()) for hostname resolution, thus enabling IPv6 support 
when resolving backend addresses (see #862780). Enabling the use of 
getaddrinfo injects the following code in the hostname resolution path 
(src/standard.c):

 #ifdef USE_GETADDRINFO
         if (global.tune.options & GTUNE_USE_GAI) {
                 struct addrinfo hints, *result;
 
                 memset(&result, 0, sizeof(result));
                 memset(&hints, 0, sizeof(hints));
                 hints.ai_family = sa->ss_family ? sa->ss_family : AF_UNSPEC;
                 hints.ai_socktype = SOCK_DGRAM;
                 hints.ai_flags = 0;
                 hints.ai_protocol = 0;
 
                 if (getaddrinfo(str, NULL, &hints, &result) == 0) {
                         if (!sa->ss_family || sa->ss_family == AF_UNSPEC)
                                 sa->ss_family = result->ai_family;
                         else if (sa->ss_family != result->ai_family)
                                 goto fail;
 
                         switch (result->ai_family) {
                         case AF_INET:
                                 memcpy((struct sockaddr_in *)sa, result->ai_addr, result->ai_addrlen);
                                 set_host_port(sa, port);
                                 return sa;
                         case AF_INET6:
                                 memcpy((struct sockaddr_in6 *)sa, result->ai_addr, result->ai_addrlen);
                                 set_host_port(sa, port);
                                 return sa;
                         }
                 }
 
                 if (result)
                         freeaddrinfo(result);
         }
 #endif

We would like to have this change migrate to Stretch, as full IPv6 support has
been a long-standing project goal and the change is not expected to have 
any negative side-effects.

Full source debdiff attached.

Thanks,
Apollon

unblock haproxy/1.7.5-2
diff -Nru haproxy-1.7.5/debian/changelog haproxy-1.7.5/debian/changelog
--- haproxy-1.7.5/debian/changelog	2017-04-04 14:25:38.000000000 +0300
+++ haproxy-1.7.5/debian/changelog	2017-05-17 13:01:45.000000000 +0300
@@ -1,3 +1,11 @@
+haproxy (1.7.5-2) unstable; urgency=medium
+
+  * Enable getaddrinfo() support, allowing resolution of hostnames to IPv6
+    addresses (Closes: #862780). Thanks to Anton Eliasson
+    <devel@antoneliasson.se>!
+
+ -- Apollon Oikonomopoulos <apoikos@debian.org>  Wed, 17 May 2017 13:01:45 +0300
+
 haproxy (1.7.5-1) unstable; urgency=medium
 
   * New upstream version release (see CHANGELOG):
diff -Nru haproxy-1.7.5/debian/rules haproxy-1.7.5/debian/rules
--- haproxy-1.7.5/debian/rules	2017-04-04 14:25:27.000000000 +0300
+++ haproxy-1.7.5/debian/rules	2017-05-17 12:58:07.000000000 +0300
@@ -12,6 +12,7 @@
 	 USE_OPENSSL=1 \
 	 USE_ZLIB=1 \
 	 USE_LUA=1 \
+	 USE_GETADDRINFO=1 \
 	 LUA_INC=/usr/include/lua5.3
 
 OS_TYPE = $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)

--- End Message ---
--- Begin Message ---
Apollon Oikonomopoulos:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Dear Release Team,
> 
> Please unblock package haproxy.
> 
> [...]
> 
> Full source debdiff attached.
> 
> Thanks,
> Apollon
> 
> unblock haproxy/1.7.5-2
> 

Unblocked, thanks.

~Niels

--- End Message ---

Reply to: