[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#774964: marked as done (unblock: xfce4-session/4.10.1-10 (pre-approval))

Your message dated Wed, 14 Jan 2015 00:10:26 +0100
with message-id <20150113231026.GE6099@ugent.be>
and subject line Re: Bug#774964: unblock: xfce4-session/4.10.1-10 (pre-approval)
has caused the Debian Bug report #774964,
regarding unblock: xfce4-session/4.10.1-10 (pre-approval)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
774964: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=774964
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package xfce4-session

Properly cleanup alternatives on removal. (#767822)

The patch is taken from packaging SVN (and therefore targets
UNRELEASED). I just verified that it works as intended.

If the patch is approved, I'll ping the maintainer to actually
upload the pending fix (or NMU it myself after a few days).

unblock xfce4-session/4.10.1-10

Andreas

PS: this is the second (after flextra) and last package in
jessie that does not clean up alternatives on removal, there might be
one or two more that do not properly clean up obsolete alternatives
after upgrades from wheezy.

diff -Nru xfce4-session-4.10.1/debian/changelog xfce4-session-4.10.1/debian/changelog
--- xfce4-session-4.10.1/debian/changelog	2014-10-24 14:32:15.000000000 +0200
+++ xfce4-session-4.10.1/debian/changelog	2014-11-02 22:47:15.000000000 +0100
@@ -1,3 +1,10 @@
+xfce4-session (4.10.1-10) UNRELEASED; urgency=medium
+
+  * debian/{pre,postrm}: correctly handle all alternatives removal.
+                                                                closes: #767822
+
+ -- Yves-Alexis Perez <corsac@debian.org>  Sun, 02 Nov 2014 22:46:14 +0100
+
 xfce4-session (4.10.1-9) unstable; urgency=medium
 
   * debian/patches:
diff -Nru xfce4-session-4.10.1/debian/postrm xfce4-session-4.10.1/debian/postrm
--- xfce4-session-4.10.1/debian/postrm	1970-01-01 01:00:00.000000000 +0100
+++ xfce4-session-4.10.1/debian/postrm	2014-11-02 22:47:15.000000000 +0100
@@ -0,0 +1,10 @@
+#!/bin/sh -e
+
+if [ "$1" = "remove" ] || [ "$1" = "disappear" ]; then
+  update-alternatives --remove x-session-manager /usr/bin/xfce4-session 
+  update-alternatives --remove x-session-manager /usr/bin/startxfce4
+fi
+
+#DEBHELPER#
+
+exit 0
diff -Nru xfce4-session-4.10.1/debian/prerm xfce4-session-4.10.1/debian/prerm
--- xfce4-session-4.10.1/debian/prerm	2012-01-02 07:42:50.000000000 +0100
+++ xfce4-session-4.10.1/debian/prerm	2014-11-02 22:47:15.000000000 +0100
@@ -2,6 +2,7 @@
 
 if [ "$1" = "remove" ]; then
   update-alternatives --remove x-session-manager /usr/bin/xfce4-session 
+  update-alternatives --remove x-session-manager /usr/bin/startxfce4
 fi
 
 #DEBHELPER#

--- End Message ---
--- Begin Message --- 
Hi,

On Sun, Jan 11, 2015 at 02:54:42PM +0100, Andreas Beckmann wrote:
> Yves just uploaded it.

Unblocked.

> > Also, please note that it's not needed to ask for pre-approval
> > for targeted fixed to RC bugs. You can just upload them to unstable and ask
> > for an unblock at that point.
> 
> I wasn't sure whether these would qualify as RC ... but I consider them
> important enough to get them cleaned up before the release.

I didn't notice that the bug was only important.

Cheers,

Ivo

--- End Message ---
Reply to: