[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#774964: unblock: xfce4-session/4.10.1-10 (pre-approval)



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package xfce4-session

Properly cleanup alternatives on removal. (#767822)

The patch is taken from packaging SVN (and therefore targets
UNRELEASED). I just verified that it works as intended.

If the patch is approved, I'll ping the maintainer to actually
upload the pending fix (or NMU it myself after a few days).

unblock xfce4-session/4.10.1-10

Andreas

PS: this is the second (after flextra) and last package in
jessie that does not clean up alternatives on removal, there might be
one or two more that do not properly clean up obsolete alternatives
after upgrades from wheezy.
diff -Nru xfce4-session-4.10.1/debian/changelog xfce4-session-4.10.1/debian/changelog
--- xfce4-session-4.10.1/debian/changelog	2014-10-24 14:32:15.000000000 +0200
+++ xfce4-session-4.10.1/debian/changelog	2014-11-02 22:47:15.000000000 +0100
@@ -1,3 +1,10 @@
+xfce4-session (4.10.1-10) UNRELEASED; urgency=medium
+
+  * debian/{pre,postrm}: correctly handle all alternatives removal.
+                                                                closes: #767822
+
+ -- Yves-Alexis Perez <corsac@debian.org>  Sun, 02 Nov 2014 22:46:14 +0100
+
 xfce4-session (4.10.1-9) unstable; urgency=medium
 
   * debian/patches:
diff -Nru xfce4-session-4.10.1/debian/postrm xfce4-session-4.10.1/debian/postrm
--- xfce4-session-4.10.1/debian/postrm	1970-01-01 01:00:00.000000000 +0100
+++ xfce4-session-4.10.1/debian/postrm	2014-11-02 22:47:15.000000000 +0100
@@ -0,0 +1,10 @@
+#!/bin/sh -e
+
+if [ "$1" = "remove" ] || [ "$1" = "disappear" ]; then
+  update-alternatives --remove x-session-manager /usr/bin/xfce4-session 
+  update-alternatives --remove x-session-manager /usr/bin/startxfce4
+fi
+
+#DEBHELPER#
+
+exit 0
diff -Nru xfce4-session-4.10.1/debian/prerm xfce4-session-4.10.1/debian/prerm
--- xfce4-session-4.10.1/debian/prerm	2012-01-02 07:42:50.000000000 +0100
+++ xfce4-session-4.10.1/debian/prerm	2014-11-02 22:47:15.000000000 +0100
@@ -2,6 +2,7 @@
 
 if [ "$1" = "remove" ]; then
   update-alternatives --remove x-session-manager /usr/bin/xfce4-session 
+  update-alternatives --remove x-session-manager /usr/bin/startxfce4
 fi
 
 #DEBHELPER#

Reply to: