Bug#774428: unblock: simpleburn/1.7.0-2
On Tue, 2015-01-06 at 22:03 +0100, John Paul Adrian Glaubitz wrote:
> On 01/06/2015 09:41 PM, Ivo De Decker wrote:
> > It seems upstream is writing the script purely with bash in mind. I wonder if
> > it wouldn't less risky (and easier) to just change the first line to
> > "#! /bin/bash". That way, the change would be limited and would still cover
> > future changes to the script.
>
> Isn't the whole point of the release goal to actually get rid
> of the bashisms? Just changing the shebang doesn't fix the actual
> problem, does it? It just shoves everything under the carpet. I
> don't think that's a reasonable way and would render the whole
> bug report with it's RC status pointless.
Release goals are not (and ttbomk never have been) RC. The bug is RC
because the script uses features outside of what policy says may be
expected from /bin/sh, without declaring that, not because of any
release goal. Changing the shebang very much fixes the policy violation.
> Yes, the diff is a bit larger, but also very repetitive.
It's also broken.
+ cdda2wav dev=$device -t $track -
2>/dev/null | flac -f -o "$title.flac" -
+- status=${PIPESTATUS[0]}
++ status=$?
The original line and suggested replacement do _not_ do the same thing.
(The original returns the status of cdda2wav, the replacement returns
the status of flac.)
Regards,
Adam
Reply to: