[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#774428: unblock: simpleburn/1.7.0-2



On 01/06/2015 09:41 PM, Ivo De Decker wrote:
> It seems upstream is writing the script purely with bash in mind. I wonder if
> it wouldn't less risky (and easier) to just change the first line to 
> "#! /bin/bash". That way, the change would be limited and would still cover
> future changes to the script.

Isn't the whole point of the release goal to actually get rid
of the bashisms? Just changing the shebang doesn't fix the actual
problem, does it? It just shoves everything under the carpet. I
don't think that's a reasonable way and would render the whole
bug report with it's RC status pointless.

Yes, the diff is a bit larger, but also very repetitive. It
isn't too much to review therefore and in the end, it would just
break simpleburn at worst, so I don't think we should be super
cautious with any changes regarding the package.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Reply to: