Bug#780272: unblock (pre-approval): uif/1.1.4-2
Control: tags -1 confirmed moreinfo
On 2015-03-11 14:42, Mike Gabriel wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> Please consider unblocking planned upload of package uif.
>
> + * debian/po:
> + + Add nl.po. Thanks to Frans Spiesschaert! (Closes: #767285).
>
> -> Probably not appropriate anymore at this time of the freeze(?).
>
> + * debian/patches:
> + + Add 0001_Debian-name-spelling.patch. Fix spelling of the Debian project
> + name and another typo in an error message. (Closes: #772496).
>
> -> Non-function, non-i18n-related fix of the "Debian" name (plus another typo).
>
> + + Add 0002_correctly-ignore-ipv4+6-only-rules.patch. Fix severe flaw in
> + IPv4-only/IPv6-only rule setup. Don't open IPv4 wholes when setting up
> + IPv6-only rules and vice versa. (Closes: #779150).
>
> -> Real RC bug that actually deserves a CVE (though I will not push that that far...).
>
> light+love,
> Mike
>
> unblock uif/1.1.4-2
>
> [...]
Ack, with one comment (see below).
>
> diff -Nru uif-1.1.4/debian/patches/0001_Debian-name-spelling.patch uif-1.1.4/debian/patches/0001_Debian-name-spelling.patch
> --- uif-1.1.4/debian/patches/0001_Debian-name-spelling.patch 1970-01-01 01:00:00.000000000 +0100
> +++ uif-1.1.4/debian/patches/0001_Debian-name-spelling.patch 2015-03-11 12:21:29.000000000 +0100
> @@ -0,0 +1,17 @@
> +Description: Fix spelling errors in error message
> +Origin: https://github.com/cajus/uif/commit/3ffeb89b134a541d15afccdc2a994e81c940f51f
> +
> +diff --git a/uif.pl b/uif.pl
> +index 63f27f3..e1b8547 100755
> +--- a/uif.pl
> ++++ b/uif.pl
> +@@ -1553,7 +1553,7 @@ sub readCommandLine {
> + }
> +
> + if ($readldap || $writeldap) {
> +- if ($LDAPENABLED == 0) { die "To use LDAP fatures be sure to install Net::LDAP from debain package libnet-ldap-perl" } ;
> ++ if ($LDAPENABLED == 0) { die "To use LDAP features be sure to install Net::LDAP from the Debian package libnet-ldap-perl" } ;
I believe you would normally write "debian" in lowercase since it is
referring to a type of package rather than the project.
> [...]
Thanks,
~Niels
Reply to: