[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#773183: marked as done ((pre-approval) unblock: systemd with #770504 fixed)

Your message dated Sun, 25 Jan 2015 23:14:14 +0100
with message-id <54C56AB6.30201@thykier.net>
and subject line Re: Bug#773183: (pre-approval) unblock: systemd with #770504 fixed
has caused the Debian Bug report #773183,
regarding (pre-approval) unblock: systemd with #770504 fixed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
773183: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773183
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: wishlist
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: pkg-systemd-maintainers@lists.alioth.debian.org

Would you be willing to let the systemd maintainers cherry-pick the
attached into a jessie-targeted version?

It is a trivial change (escalate the level of a log line from info to
warning) and would make it much easier to diagnose and fix circular
dependencies between units. At the moment, systemd logs the first unit
in the cycle and the points at which it tried breaking the cycle,
but the other units involved are not logged unless 'debug' or
a non-default 'systemd.log_level' is present on the kernel command-line.

    S

>From 14fe721b5f6d8457cc8737fa75f2ed79e7fa534b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
Date: Sun, 2 Nov 2014 12:10:42 -0500
Subject: [PATCH] Raise level of 'Found dependency...' lines

This way they always show up together with 'Found ordering cycle...'.
Ordering cycles are a serious error and a major pain to debug. If
quiet is enabled, only the first and the last line of output are
shown:

systemd[1]: Found ordering cycle on basic.target/start
systemd[1]: Breaking ordering cycle by deleting job timers.target/start
systemd[1]: Job timers.target/start deleted to break ordering cycle starting with basic.target/start

which isn't particularly enlightening. So just show the whole message
at the same level.

Bug-RedHat: https://bugzilla.redhat.com/show_bug.cgi?id=1158206
Bug-Debian: https://bugs.debian.org/770504
Origin: upstream, 218, commit:14fe721b5f6d
---
 src/core/transaction.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/core/transaction.c b/src/core/transaction.c
index 488cb86..bbaa6da 100644
--- a/src/core/transaction.c
+++ b/src/core/transaction.c
@@ -376,9 +376,9 @@ static int transaction_verify_order_one(Transaction *tr, Job *j, Job *from, unsi
                 for (k = from; k; k = ((k->generation == generation && k->marker != k) ? k->marker : NULL)) {
 
                         /* logging for j not k here here to provide consistent narrative */
-                        log_info_unit(j->unit->id,
-                                      "Found dependency on %s/%s",
-                                      k->unit->id, job_type_to_string(k->type));
+                        log_warning_unit(j->unit->id,
+                                         "Found dependency on %s/%s",
+                                         k->unit->id, job_type_to_string(k->type));
 
                         if (!delete && hashmap_get(tr->jobs, k->unit) &&
                             !unit_matters_to_anchor(k->unit, k)) {
-- 
2.1.3

--- End Message ---
--- Begin Message --- 
On 2014-12-26 22:54, Ivo De Decker wrote:
> Control: tags -1 moreinfo
> 
> Simon,
> 
> [...]
> 
> Please remove the moreinfo tag once the new version is in unstable.
> 
> Cheers,
> 
> Ivo
> 
> 

Hi,

This patch was included in systemd/215-10, which just got unblocked (in
#775265).

Thanks,
~Niels

--- End Message ---
Reply to: