[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#767955: marked as done (unblock: libdbi/0.9.0-4)

Your message dated Mon, 03 Nov 2014 18:00:30 +0000
with message-id <78de432be3bcc2d01b4a5271fc49f1c4@mail.adsl.funky-badger.org>
and subject line Re: Bug#767955: unblock: libdbi/0.9.0-4
has caused the Debian Bug report #767955,
regarding unblock: libdbi/0.9.0-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
767955: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767955
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock the new upload of libdbi. It fixes RC bug 764130 [1] with
upstream commit[2]. I attach the debdiff.

Thanks,
Laszlo/GCS

unblock libdbi/0.9.0-4

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764130
[2] http://sourceforge.net/p/libdbi/libdbi/ci/cdc447994cf767ae03fa6b0ca663a6b2a89469dd/

diff -Nru libdbi-0.9.0/debian/changelog libdbi-0.9.0/debian/changelog
--- libdbi-0.9.0/debian/changelog	2014-09-21 08:57:48.000000000 +0000
+++ libdbi-0.9.0/debian/changelog	2014-11-01 15:12:02.000000000 +0000
@@ -1,3 +1,10 @@
+libdbi (0.9.0-4) unstable; urgency=medium
+
+  * Backport fix for double-free in dbi_shutdown_r() (closes: #764130).
+  * Update Standards-Version to 3.9.6 .
+
+ -- Laszlo Boszormenyi (GCS) <gcs@debian.org>  Sat, 01 Nov 2014 12:06:55 +0000
+
 libdbi (0.9.0-3) unstable; urgency=medium
 
   * Backport important upstream patches:
diff -Nru libdbi-0.9.0/debian/control libdbi-0.9.0/debian/control
--- libdbi-0.9.0/debian/control	2014-04-04 15:34:26.000000000 +0000
+++ libdbi-0.9.0/debian/control	2014-11-01 14:30:18.000000000 +0000
@@ -7,7 +7,7 @@
                dh-autoreconf,
                docbook-dsssl,
                jadetex
-Standards-Version: 3.9.5
+Standards-Version: 3.9.6
 Vcs-Git: git://anonscm.debian.org/collab-maint/libdbi.git
 Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/libdbi.git
 Homepage: http://libdbi.sourceforge.net/
diff -Nru libdbi-0.9.0/debian/patches/fix_double-free_in_dbi_shutdown_r.patch libdbi-0.9.0/debian/patches/fix_double-free_in_dbi_shutdown_r.patch
--- libdbi-0.9.0/debian/patches/fix_double-free_in_dbi_shutdown_r.patch	1970-01-01 00:00:00.000000000 +0000
+++ libdbi-0.9.0/debian/patches/fix_double-free_in_dbi_shutdown_r.patch	2014-11-01 15:06:28.000000000 +0000
@@ -0,0 +1,32 @@
+Description: dbi_conn_close(): do not return early if conn->connection is NULL
+Origin: upstream, http://sourceforge.net/p/libdbi/libdbi/ci/cdc447994cf767ae03fa6b0ca663a6b2a89469dd/tree/src/dbi_main.c?diff=06e738a61a06f3e6720c84210b7cce47b82e0c7f
+Bug-Debian: https://bugs.debian.org/764130
+Author: Markus Hoenicka <markus.hoenicka@mhoenicka.de>
+Last-Update: 2014-11-01
+
+---
+
+--- libdbi-0.9.0.orig/src/dbi_main.c
++++ libdbi-0.9.0/src/dbi_main.c
+@@ -592,13 +592,17 @@ void dbi_conn_close(dbi_conn Conn) {
+ 	  return;
+ 	}
+ 
+-	if (!(conn->connection)) {
+-	  free(conn);
+-	  return;
+-	}
++	/* if (!(conn->connection)) { */
++	/*   free(conn); */
++	/*   return; */
++	/* } */
+ 	
+ 	_update_internal_conn_list(conn, -1);
+ 	
++	/* give drivers a chance to clean up even if there is no
++	   connection. It is assumed that
++	   driver->functions->disconnects() checks the existence of
++	   conn->connection */
+ 	conn->driver->functions->disconnect(conn);
+ 	conn->driver = NULL;
+ 	dbi_conn_clear_options(Conn);
diff -Nru libdbi-0.9.0/debian/patches/series libdbi-0.9.0/debian/patches/series
--- libdbi-0.9.0/debian/patches/series	2014-09-21 09:02:20.000000000 +0000
+++ libdbi-0.9.0/debian/patches/series	2014-11-01 15:02:53.000000000 +0000
@@ -1,2 +1,3 @@
 fix_memory_leak_if_not_connected.patch
 fix_possible_access_to_unallocated_memory.patch
+fix_double-free_in_dbi_shutdown_r.patch

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message --- 
On 2014-11-03 17:11, Laszlo Boszormenyi (GCS) wrote:
Please unblock the new upload of libdbi. It fixes RC bug 764130 [1] with 
upstream commit[2]. I attach the debdiff.


Done earlier today; thanks for the fix.

Regards,

Adam

--- End Message ---
Reply to: