[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#773105: marked as done (unblock: ifupdown/0.7.51)

Your message dated Thu, 25 Dec 2014 16:39:26 +0000
with message-id <c9a984cecf977f3e3af3a02018da7d55@mail.adsl.funky-badger.org>
and subject line Re: Bug#773105: unblock: ifupdown/0.7.51
has caused the Debian Bug report #773105,
regarding unblock: ifupdown/0.7.51
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
773105: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773105
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package ifupdown

The last upload has broken some things, so I need to unbreak them back.

This patch should enable the boot process to continue even when the link
isn't available as it used to be before 0.7.50 (see #771943).

unblock ifupdown/0.7.51

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.12-1-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/mksh

diff -Nru ifupdown-0.7.50/debian/changelog ifupdown-0.7.51/debian/changelog
--- ifupdown-0.7.50/debian/changelog	2014-11-29 14:32:55.000000000 +0100
+++ ifupdown-0.7.51/debian/changelog	2014-12-14 12:34:21.000000000 +0100
@@ -1,3 +1,11 @@
+ifupdown (0.7.51) unstable; urgency=medium
+
+  [ Michael Biebl ]
+  * Check the hotplug interface operstate to avoid blocking the
+    boot process (Closes: #771943).
+
+ -- Andrew Shadura <andrewsh@debian.org>  Sun, 14 Dec 2014 12:34:19 +0100
+
 ifupdown (0.7.50) unstable; urgency=medium
 
   [ Andrew Shadura ]
diff -Nru ifupdown-0.7.50/debian/networking.init ifupdown-0.7.51/debian/networking.init
--- ifupdown-0.7.50/debian/networking.init	2014-11-29 14:08:42.000000000 +0100
+++ ifupdown-0.7.51/debian/networking.init	2014-12-14 12:30:34.000000000 +0100
@@ -105,7 +105,8 @@
 			    do
 				    link=${iface##:*}
 				    link=${link##.*}
-				    if [ -e "/sys/class/net/$link" ]
+				    ip link set "$iface" up || true
+				    if [ -e "/sys/class/net/$link" ] && [ "$(cat /sys/class/net/$link/operstate)" = up ]
 				    then
 					    echo "$iface"
 				    fi

--- End Message ---
--- Begin Message --- 
On 2014-12-14 13:59, Andrew Shadura wrote:

Hello,

On Sun, 14 Dec 2014 13:40:49 +0100
Michael Biebl <biebl@debian.org> wrote:


This patch should probably be extended and the
'ip link set "$iface" up || true' call guarded with a check for the
network interface, otherwise we'll generate an error message for
interfaces which aren't available during boot.


Makes sense, yes.


It would probably also be good to add a short comment that the
interface is upped so link detection (check for operstate) actually
works.


Surely.


Unblocked.

Regards,

Adam

--- End Message ---
Reply to: