[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#773105: unblock: ifupdown/0.7.51



Hello,

On Sun, 14 Dec 2014 13:40:49 +0100
Michael Biebl <biebl@debian.org> wrote:

> This patch should probably be extended and the
> 'ip link set "$iface" up || true' call guarded with a check for the
> network interface, otherwise we'll generate an error message for
> interfaces which aren't available during boot.

Makes sense, yes.

> It would probably also be good to add a short comment that the
> interface is upped so link detection (check for operstate) actually
> works.

Surely.

-- 
Cheers,
  Andrew
diff --git a/debian/changelog b/debian/changelog
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+ifupdown (0.7.51) unstable; urgency=medium
+
+  [ Michael Biebl ]
+  * Check the hotplug interface operstate to avoid blocking the
+    boot process (Closes: #771943).
+
+ -- Andrew Shadura <andrewsh@debian.org>  Sun, 14 Dec 2014 12:34:19 +0100
+
 ifupdown (0.7.50) unstable; urgency=medium
 
   [ Andrew Shadura ]
diff --git a/debian/networking.init b/debian/networking.init
--- a/debian/networking.init
+++ b/debian/networking.init
@@ -107,7 +107,12 @@ ifup_hotplug () {
 				    link=${link##.*}
 				    if [ -e "/sys/class/net/$link" ]
 				    then
+					# link detection does not work unless we up the link
+					ip link set "$iface" up || true
+					if [ "$(cat /sys/class/net/$link/operstate)" = up ]
+					then
 					    echo "$iface"
+					fi
 				    fi
 			    done)
 	    if [ -n "$ifaces" ]

Attachment: signature.asc
Description: PGP signature


Reply to: