Bug#769880: unblock: hello/2.9-2

[Santiago Vila <sanvila@unex.es>]

On Tue, Nov 18, 2014 at 07:06:46PM +0100, Niels Thykier wrote:
> Control: tags -1 moreinfo
> 
> On 2014-11-17 10:50, Santiago Vila wrote:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian.org@packages.debian.org
> > Usertags: unblock
> > 
> > I'd like to ask the unblocking of "hello".
> > 
> > It fixes #767172 which is some kind of brown-paper bug (one of the
> > star features of "hello" is that it says "hello" according to LANG,
> > which was not the case).
> > 
> > I would have liked to include the copyright file contributed by Osamu Aoki,
> > but unfortunately didn't find the time to review it appropriately, so
> > this is deferred for "stretch".
> > 
> > debdiff follows, excluding the config.guess/config.sub part.
> > 
> > Thanks.
> > 
> > diff -Nru --exclude '*99-config-guess-config-sub' hello-2.9/debian/changelog hello-2.9/debian/changelog
> > --- hello-2.9/debian/changelog	2014-04-12 15:23:34.000000000 +0200
> > +++ hello-2.9/debian/changelog	2014-11-06 12:04:53.000000000 +0100
> > @@ -1,3 +1,17 @@
> > +hello (2.9-2) unstable; urgency=low
> > +
> > +  [...]
> > +  * Use Breaks: hello-debhelper (<< 2.9), not Conflicts,
> > +    as hello-debhelper is deprecated.
> > +  [...]
> > +
> > + -- Santiago Vila <sanvila@debian.org>  Thu, 06 Nov 2014 12:03:40 +0100
> > +
> >  hello (2.9-1) unstable; urgency=low
> >  
> > [...]
> 
> Hi,
> 
> You *also* need a Replaces, since hello ships files that hello-debhelper
> used to ship.  Breaks without Replaces is insufficient to avoid upgrade
> issues for this case.

Of course. There *is* a Replaces.

This was hello 2.9-1

Conflicts: hello-traditional, hello-debhelper (<< 2.9)
Replaces: hello-traditional, hello-debhelper (<< 2.9)

And this is hello 2.9-2

Conflicts: hello-traditional
Replaces: hello-traditional, hello-debhelper (<< 2.9)
Breaks: hello-debhelper (<< 2.9)

So I'm using Breaks and Replaces for hello-debhelper because it's a
dummy package, and I am still using Conflicts and Replaces for
hello-traditional, because they will always conflict (when they will
always conflict, "Conflicts" should be used and not "Breaks")

This change was prompted by a bug from Osamu Aoki, but in his bug he
proposed using Breaks for everything which is not completely correct.
I'm cherrypicking the right thing from his proposal and leaving the
rest of the bug (including the copyright file) for "stretch".

Thanks.