Your message dated Mon, 17 Nov 2014 07:36:45 +0100 with message-id <5469977D.2000800@thykier.net> and subject line Re: Bug#769849: unblock: redmine-plugin-pretend/0.0.2+git20130821-2 has caused the Debian Bug report #769849, regarding unblock: redmine-plugin-pretend/0.0.2+git20130821-2 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 769849: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769849 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: unblock: redmine-plugin-pretend/0.0.2+git20130821-2
- From: Dmitry Smirnov <onlyjob@debian.org>
- Date: Mon, 17 Nov 2014 12:26:11 +1100
- Message-id: <[🔎] 1845322.yjrQ73q67N@debstor>
Package: release.debian.org Severity: normal User: release.debian.org@packages.debian.org Usertags: unblock redmine-plugin-pretend/0.0.2+git20130821-2 Please unblock the above package. It contains an essential Redmine compatibility adaptation which is necessary to avoid the following error on start or upgrade of Redmine: ~~~~ An error occurred while loading the routes definition of redmine_pretend plugin (/usr/share/redmine/plugins/redmine_pretend/config/routes.rb): You should not use the `match` method in your router without specifying an HTTP method. If you want to expose your action to both GET and POST, add `via: [:get, :post]` option. If you want to expose your action to GET, use `get` in the router: Instead of: match "controller#action" Do: get "controller#action". Error when running rake db:migrate, check database configuration. ~~~~ Patch is trivial and only changes "match" to "get" in "config/routes.rb": ~~~~ --- a/config/routes.rb +++ b/config/routes.rb @@ -1,8 +1,8 @@ if Rails::VERSION::MAJOR >= 3 RedmineApp::Application.routes.draw do - match 'admin/pretend_to/:id' => 'application#pretend_to', :as => 'pretend_to' - match 'admin/unpretend' => 'application#unpretend', :as => 'unpretend' + get 'admin/pretend_to/:id' => 'application#pretend_to', :as => 'pretend_to' + get 'admin/unpretend' => 'application#unpretend', :as => 'unpretend' end else ActionController::Routing::Routes.draw do |map| map.pretend_to 'admin/pretend_to/:id', :controller => 'application', :action => 'pretend_to' ~~~~ See full list of changes in repository: http://anonscm.debian.org/cgit/collab-maint/redmine-plugin-pretend.git/log/ Thank you. -- All the best, Dmitry Smirnov.Attachment: signature.asc
Description: This is a digitally signed message part.
--- End Message ---
--- Begin Message ---
- To: Dmitry Smirnov <onlyjob@debian.org>, 769849-done@bugs.debian.org
- Subject: Re: Bug#769849: unblock: redmine-plugin-pretend/0.0.2+git20130821-2
- From: Niels Thykier <niels@thykier.net>
- Date: Mon, 17 Nov 2014 07:36:45 +0100
- Message-id: <5469977D.2000800@thykier.net>
- In-reply-to: <[🔎] 1845322.yjrQ73q67N@debstor>
- References: <[🔎] 1845322.yjrQ73q67N@debstor>
On 2014-11-17 02:26, Dmitry Smirnov wrote: > Package: release.debian.org > Severity: normal > User: release.debian.org@packages.debian.org > Usertags: unblock > > redmine-plugin-pretend/0.0.2+git20130821-2 > > Please unblock the above package. > > It contains an essential Redmine compatibility adaptation which is necessary > to avoid the following error on start or upgrade of Redmine: > > ~~~~ > An error occurred while loading the routes definition of redmine_pretend plugin (/usr/share/redmine/plugins/redmine_pretend/config/routes.rb): > You should not use the `match` method in your router without specifying an HTTP method. > If you want to expose your action to both GET and POST, add `via: [:get, :post]` option. > If you want to expose your action to GET, use `get` in the router: > Instead of: match "controller#action" > Do: get "controller#action". > Error when running rake db:migrate, check database configuration. > ~~~~ > > Patch is trivial and only changes "match" to "get" in "config/routes.rb": > > [...] > See full list of changes in repository: > > http://anonscm.debian.org/cgit/collab-maint/redmine-plugin-pretend.git/log/ > > Thank you. > Unblocked, thanks. ~Niels
--- End Message ---