[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#769849: unblock: redmine-plugin-pretend/0.0.2+git20130821-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

    redmine-plugin-pretend/0.0.2+git20130821-2

Please unblock the above package.

It contains an essential Redmine compatibility adaptation which is necessary
to avoid the following error on start or upgrade of Redmine:

~~~~
An error occurred while loading the routes definition of redmine_pretend plugin (/usr/share/redmine/plugins/redmine_pretend/config/routes.rb):
You should not use the `match` method in your router without specifying an HTTP method.
If you want to expose your action to both GET and POST, add `via: [:get, :post]` option.
If you want to expose your action to GET, use `get` in the router:
Instead of: match "controller#action"
Do: get "controller#action".
Error when running rake db:migrate, check database configuration.
~~~~

Patch is trivial and only changes "match" to "get" in "config/routes.rb":

~~~~
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -1,8 +1,8 @@
 if Rails::VERSION::MAJOR >= 3
 RedmineApp::Application.routes.draw do
- match 'admin/pretend_to/:id' => 'application#pretend_to', :as => 'pretend_to'
- match 'admin/unpretend' => 'application#unpretend', :as => 'unpretend'
+ get 'admin/pretend_to/:id' => 'application#pretend_to', :as => 'pretend_to'
+ get 'admin/unpretend' => 'application#unpretend', :as => 'unpretend'
 end
 else
 ActionController::Routing::Routes.draw do |map|
 map.pretend_to 'admin/pretend_to/:id', :controller => 'application', :action => 'pretend_to'
~~~~

See full list of changes in repository:

    http://anonscm.debian.org/cgit/collab-maint/redmine-plugin-pretend.git/log/

Thank you.

-- 
All the best,
 Dmitry Smirnov.

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: