Bug#768930: unblock: pynag and syslog-nagios-bridge
Excerpts from Daniel Pocock's message of 2014-11-11 00:59:36 -0800:
> On 11/11/14 06:05, Clint Byrum wrote:
> > Excerpts from Daniel Pocock's message of 2014-11-10 12:19:19 -0800:
> >> On 10/11/14 20:56, Niels Thykier wrote:
> >>> Control: tags -1 moreinfo
> >>>
> >>> On Mon, 10 Nov 2014 10:31:03 +0100 Daniel Pocock <daniel@pocock.pro> wrote:
> >>>> Package: release.debian.org
> >>>>
> >>>>
> >>>>
> >>>> syslog-nagios-bridge requires pynag 0.9.1+, older versions have a bug in
> >>>> check result file generation:
> >>>>
> >>>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768928
> >>>>
> >>>>
> >>>> I added a constraint in syslog-nagios-bridge well before the freeze so
> >>>> it would not propagate to testing until pynag 0.9.1 was uploaded:
> >>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763378
> >>>>
> >>>> Note that the pynag upload in unstable is also cleaning out minified
> >>>> jquery and other things that make the package more compliant with Debian
> >>>> policy
> >>>>
> >>>>
> >>>> [...]
> >>> Hi,
> >>>
> >>> I am afraid I will have to reject this request in its current form.
> >>>
> >>> The changes to pynag is beyond what can be reasonably reviewed and
> >>> indeed it is not a targeted fix for #768928. The changes to
> >>> syslog-nagios-bridge are reasonable and I could accept them, but I
> >>> understand it is of no use without pynag as well.
> >>>
> >>> Can you please provide a targeted fix for pynag?
> >> This (just a few lines) could be dropped into
> >> debian/patches/checkresult_fix.patch
> >>
> >> https://github.com/pynag/pynag/commit/3aad1176bca4b2f39c2c851396d30647efbf2bed
> >>
> >> Clint, would you be happy to upload 0.8.9 with that or would you like me
> >> to NMU perhaps?
> >>
> >> Or is there any reason why the whole 0.9.1 should be considered for jessie?
> > I think we should unblock 0.9.1.
>
> Release team have been a bit reluctant to unblock whole new versions
> without any justification at all
>
> In this case though, maybe they can accept that there was a good reason
> why it wasn't in testing before the freeze:
>
> a) 0.9.1 was tagged 5 August
>
> b) I sent a private email to Palli on 14 August about the bug and
> uploading 0.9.1
>
> c) sent follow up and commented on the bug tracker 29 September
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763378#10
>
> d) noticed Palli's email bouncing on 3 November, you then made the
> upload immediately, also removing some jquery artifacts to make it more
> dfsg compliant
>
> e) syslog-nagios-bridge is the only dependent package that I know of and
> I have been testing that against pynag v0.9.1 locally. Do you know of
> any other packages using pynag as a dependency?
>
> It appears that a range of issues were fixed upstream in 0.9.0 and 0.9.1
> - do you know if any of these issues justify an unblock for 0.9.1 or
> maybe the collection of all these issues together justifies an unblock?
> https://github.com/pynag/pynag/issues?q=is%3Aissue+is%3Aclosed
The upload only missed being in testing by 3 days, and fixes a number
of issues. We don't want to ship with an old API. Seems like an easy
unblock this early in the freeze.
Reply to: