[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#767266: plymouth: makes update-initramfs fail because label.so is missing



On Tue, 28 Oct 2014 23:08:22 +0100 =?UTF-8?B?UmFwaGHDq2wgSEFMSU1J?=
<raphael.halimi@gmail.com> wrote:
> Package: plymouth
> Version: 0.9.0-8
> Severity: serious
> 
> Version 0.9.0-8 of the package fixed bug #764644 but now another file
> needed for graphical themes is missing: label.so.
> 
> If a graphical theme was previously chosen, this makes
> update-initramfs fail on removal of plymouth-themes because label.so
> is needed in /usr/share/initramfs-tools/hooks/plymouth. After that,
> if the user doesn't revert back to a text-only theme, this bug makes
> install/upgrade/remove of other kernel-related  packages fail too
> (hence the "serious" severity).

OK, I'm thinking about the attached patch to fix this issue.

The initial answer on the unblock bug was quite negative about
splitting the package (this could still be done in next (Stretch))
release. This patch is less invasive and has higher chances of being
accepted.

The only issue of not having the label.so file installed in the
initramfs is the fact that some text might not be displayed (according
to upstream).

What do you think?

Cheers,

Laurent Bigonville
commit a4aa8e3d231742c513476db5eaa94b45b1062326
Author: Laurent Bigonville <bigon@bigon.be>
Date:   Sun Nov 9 13:31:02 2014 +0100

    debian/local/plymouth.hook: Test if the plugin is present on disk before trying to copy it to the initramfs (Closes: #767170)

diff --git a/debian/changelog b/debian/changelog
index 53d6a84..9d83153 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,8 +3,10 @@ plymouth (0.9.0-9) UNRELEASED; urgency=medium
   * debian/control: Add a dependency against init-system-helpers as we are
     explicitly using deb-systemd-helper in the plymouth postinst script
     (Closes: #767937)
+  * debian/local/plymouth.hook: Test if the plugin is present on disk before
+    trying to copy it to the initramfs (Closes: #767170)
 
- -- Laurent Bigonville <bigon@debian.org>  Mon, 03 Nov 2014 16:38:25 +0100
+ -- Laurent Bigonville <bigon@debian.org>  Sun, 09 Nov 2014 13:30:01 +0100
 
 plymouth (0.9.0-8) unstable; urgency=medium
 
diff --git a/debian/local/plymouth.hook b/debian/local/plymouth.hook
index abd0a60..a1a82a1 100644
--- a/debian/local/plymouth.hook
+++ b/debian/local/plymouth.hook
@@ -65,7 +65,12 @@ copy_exec /sbin/plymouthd
 
 for PLUGIN in ${PLUGINS}
 do
-	copy_exec ${PLUGIN_PATH}/${PLUGIN}
+	if [ -f ${PLUGIN_PATH}/${PLUGIN} ]
+	then
+		copy_exec ${PLUGIN_PATH}/${PLUGIN}
+	else
+		echo "W: plymouth plugin ${PLUGIN} is missing, the selected theme might not work as expected."
+	fi
 done
 
 # copy base themes and logo

Reply to: