Bug#736080: pu: package xfce4-weather-plugin/0.7.4-5
Package: release.debian.org
Severity: normal
Owner: pkg-xfce-devel@lists.alioth.debian.org
User: release.debian.org@packages.debian.org
Usertags: pu
Hi,
it seems that the weather.com format changed again, in a way which makes
xfce4-weather-plugin crash in Wheezy (see #735478). This doesn't affect
Jessie/sid where it doesn't use weather.com anymore.
A tiny patch fixes the issue, so it'd be nice if this could be allowed
to go to PU.
Debdiff is attached.
Thanks in advance,
--
Yves-Alexis
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (450, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru xfce4-weather-plugin-0.7.4/debian/changelog xfce4-weather-plugin-0.7.4/debian/changelog
--- xfce4-weather-plugin-0.7.4/debian/changelog 2013-10-24 22:18:00.000000000 +0200
+++ xfce4-weather-plugin-0.7.4/debian/changelog 2014-01-19 15:56:44.000000000 +0100
@@ -1,3 +1,10 @@
+xfce4-weather-plugin (0.7.4-5) UNRELEASED; urgency=medium
+
+ * debian/patches:
+ - 02_NULL-hi added, fix cases where <hi> element is empty. closes: #735478
+
+ -- Yves-Alexis Perez <corsac@debian.org> Sun, 19 Jan 2014 15:55:39 +0100
+
xfce4-weather-plugin (0.7.4-4) wheezy; urgency=low
* debian/patches:
diff -Nru xfce4-weather-plugin-0.7.4/debian/patches/02_NULL-hi.patch xfce4-weather-plugin-0.7.4/debian/patches/02_NULL-hi.patch
--- xfce4-weather-plugin-0.7.4/debian/patches/02_NULL-hi.patch 1970-01-01 01:00:00.000000000 +0100
+++ xfce4-weather-plugin-0.7.4/debian/patches/02_NULL-hi.patch 2014-01-19 15:55:33.000000000 +0100
@@ -0,0 +1,12 @@
+--- a/panel-plugin/weather-parsers.c
++++ b/panel-plugin/weather-parsers.c
+@@ -301,7 +286,8 @@ parse_dayf (xmlNode *cur_node)
+ if (NODE_IS_TYPE (cur_node, "hi"))
+ {
+ ret->hi = DATA (cur_node);
+- g_assert (ret->hi != NULL);
++ if (ret->hi == NULL);
++ ret->hi = g_strdup("NA");
+ }
+ else if (NODE_IS_TYPE (cur_node, "low"))
+ {
diff -Nru xfce4-weather-plugin-0.7.4/debian/patches/series xfce4-weather-plugin-0.7.4/debian/patches/series
--- xfce4-weather-plugin-0.7.4/debian/patches/series 2013-10-24 21:58:04.000000000 +0200
+++ xfce4-weather-plugin-0.7.4/debian/patches/series 2014-01-19 15:56:06.000000000 +0100
@@ -1,2 +1,3 @@
00_license.patch
01_uri_change.patch
+02_NULL-hi.patch
Reply to: