Bug#727639: pu: package xfce4-weather-plugin/0.7.4-3+b1
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: pu
Hi,
I was recently made aware of an issue with the Xfce weather plugin in
Wheezy. This versions uses weather.com API, and the URL has changed,
which breaks the plugin.
An update to the plugin is only a matter of updating the URL, so here's
a proposed debdiff doing that.
Please tell me if/when it is ok to upload to stable.
Same thing applies to Squeeze, although I'm not sure it makes sense to
do an oldstable upload.
Regards,
--
Yves-Alexis
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (450, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.11-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Differences in xfce4-weather-plugin between 0.7.4-3 and 0.7.4-4
diff -Nru xfce4-weather-plugin-0.7.4/debian/changelog xfce4-weather-plugin-0.7.4/debian/changelog
--- xfce4-weather-plugin-0.7.4/debian/changelog 2011-11-18 10:48:52.000000000 +0100
+++ xfce4-weather-plugin-0.7.4/debian/changelog 2013-10-24 21:47:31.000000000 +0200
@@ -1,3 +1,10 @@
+xfce4-weather-plugin (0.7.4-4) UNRELEASED; urgency=low
+
+ * debian/patches:
+ - 01_uri_change added, update weather.com API URI. closes: #727628
+
+ -- Yves-Alexis Perez <corsac@debian.org> Thu, 24 Oct 2013 21:46:58 +0200
+
xfce4-weather-plugin (0.7.4-3) unstable; urgency=low
* Brown paper bag release.
diff -Nru xfce4-weather-plugin-0.7.4/debian/patches/01_uri_change.patch xfce4-weather-plugin-0.7.4/debian/patches/01_uri_change.patch
--- xfce4-weather-plugin-0.7.4/debian/patches/01_uri_change.patch 1970-01-01 01:00:00.000000000 +0100
+++ xfce4-weather-plugin-0.7.4/debian/patches/01_uri_change.patch 2013-10-24 21:46:43.000000000 +0200
@@ -0,0 +1,64 @@
+Index: xfce4-weather-plugin-0.7.4/panel-plugin/weather-search.c
+===================================================================
+--- xfce4-weather-plugin-0.7.4.orig/panel-plugin/weather-search.c 2011-02-02 20:31:29.000000000 +0000
++++ xfce4-weather-plugin-0.7.4/panel-plugin/weather-search.c 2013-10-24 19:29:21.000000000 +0100
+@@ -177,11 +177,11 @@
+ gtk_widget_set_sensitive(dialog->find_button, FALSE);
+ gtk_dialog_set_response_sensitive(GTK_DIALOG(dialog->dialog), GTK_RESPONSE_ACCEPT, FALSE);
+
+- url = g_strdup_printf ("/search/search?where=%s", sane_str);
++ url = g_strdup_printf ("/wxdata/search/search?where=%s", sane_str);
+ g_free (sane_str);
+
+ gtk_tree_view_column_set_title(dialog->column, _("Searching..."));
+- weather_http_receive_data ("xoap.weather.com", url,
++ weather_http_receive_data ("wxdata.weather.com", url,
+ dialog->proxy_host, dialog->proxy_port,
+ cb_searchdone, dialog);
+
+@@ -503,10 +503,10 @@
+ }
+ g_free(full_loc);
+
+- url = g_strdup_printf ("/search/search?where=%s", sane_str);
++ url = g_strdup_printf ("/wxdata/search/search?where=%s", sane_str);
+ g_free (sane_str);
+
+- weather_http_receive_data ("xoap.weather.com", url,
++ weather_http_receive_data ("wxdata.weather.com", url,
+ data->proxy_host, data->proxy_port,
+ cb_geo_searchdone, data);
+ g_free(url);
+Index: xfce4-weather-plugin-0.7.4/panel-plugin/weather-summary.c
+===================================================================
+--- xfce4-weather-plugin-0.7.4.orig/panel-plugin/weather-summary.c 2011-02-02 20:31:29.000000000 +0000
++++ xfce4-weather-plugin-0.7.4/panel-plugin/weather-summary.c 2013-10-24 19:28:31.000000000 +0100
+@@ -215,7 +215,7 @@
+ pixbuf = gdk_pixbuf_new_from_file(path, NULL);
+ g_free(path);
+ if (pixbuf == NULL) {
+- weather_http_receive_data ("xoap.weather.com", "/web/common/twc/logos/web_73x55.jpg",
++ weather_http_receive_data ("www.weather.com", "/web/common/twc/logos/web_73x55.jpg",
+ data->proxy_host, data->proxy_port, logo_fetched, image);
+ } else {
+ gtk_image_set_from_pixbuf(GTK_IMAGE(image), pixbuf);
+Index: xfce4-weather-plugin-0.7.4/panel-plugin/weather.c
+===================================================================
+--- xfce4-weather-plugin-0.7.4.orig/panel-plugin/weather.c 2011-02-02 20:31:29.000000000 +0000
++++ xfce4-weather-plugin-0.7.4/panel-plugin/weather.c 2013-10-24 19:27:17.000000000 +0100
+@@ -377,13 +377,13 @@
+ }
+
+ /* build url */
+- url = g_strdup_printf ("/weather/local/%s?cc=*&dayf=%d&unit=%c&link=xoap&prod=xoap&par=%s&key=%s",
++ url = g_strdup_printf ("/wxdata/weather/local/%s?cc=*&dayf=%d&unit=%c&link=xoap&prod=xoap&par=%s&key=%s",
+ data->location_code, XML_WEATHER_DAYF_N,
+ data->unit == METRIC ? 'm' : 'i',
+ PARTNER_ID, LICENSE_KEY);
+
+ /* start receive thread */
+- weather_http_receive_data ("xoap.weather.com", url, data->proxy_host,
++ weather_http_receive_data ("wxdata.weather.com", url, data->proxy_host,
+ data->proxy_port, cb_update, data);
+
+ /* cleanup */
diff -Nru xfce4-weather-plugin-0.7.4/debian/patches/series xfce4-weather-plugin-0.7.4/debian/patches/series
--- xfce4-weather-plugin-0.7.4/debian/patches/series 2011-11-18 08:01:24.000000000 +0100
+++ xfce4-weather-plugin-0.7.4/debian/patches/series 2013-10-24 21:48:40.000000000 +0200
@@ -1 +1,2 @@
00_license.patch
+01_uri_change.patch
Reply to: