[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#698997: unblock: italc/1:1.0.13-1.4



On Mon, 28 Jan 2013 03:27:00 Adam D. Barratt wrote:
> On Sat, 2013-01-26 at 22:49 +1100, Dmitry Smirnov wrote:
> > In other words I'm removing failure point: unnecessary check for library
> > in wrong  location. "Simply removing the error message" is enough to fix
> > the problem.
> > 
> > I hope it makes sense.
> 
> Well, yes, but it would have been better to fix the test to properly
> detect the libraries in the face of multi-arch, imho.

Why? Linker looks for library in more than one location. If linker can't find 
library it'll FTBFS with better error message than the erroneous check 
produces. Therefore the test is completely redundant.

From maintainability point of view because the check is redundant
it's better to drop it completely and reduce maintenance burden.

> However, on the
> basis that it does appear to resolve the issue in this case; unblocked.

Thank you. :)

-- 
Best wishes,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

The man who does not do his own thinking is a slave, and is a traitor
to himself and to his fellow-men.
         -- Robert G. Ingersoll, "The Liberty
            of Man, Woman and Child" 1877


Reply to: