[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#698997: unblock: italc/1:1.0.13-1.4



On Sat, 26 Jan 2013 21:50:14 Adam D. Barratt wrote:
> 
> >     + added new "qtpath.patch" to avoid fatal error for wrong path
> >       to libraries.
> 
> I may be missing something here, but the patch simply removes the error
> message. Presumably the fact that the error is being raised in the first
> place indicates an actual problem? If not then the test seems somewhat
> redundant in the first place.
> 

It is a *fatal* error message that is always wrong because it looking for 
library in hardcoded non-multiarch location. Therefore removing it is a 
minimalistic change to fix the problem which is exactly a failure to find 
library where it can't be. Of course there are different ways to fix it but 
I've chosen an easy and straightforward one which works.

In other words I'm removing failure point: unnecessary check for library in 
wrong  location. "Simply removing the error message" is enough to fix the 
problem.

I hope it makes sense.

-- 
Cheers,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

Believing is easier than thinking. Hence so many more believers than
thinkers.
        -- Bruce Calvert


Reply to: