Re: php-mdb2: fix for bug#571702 in squeeze?
On Tue, May 08, 2012 at 04:02:49PM +0800, Thomas Goirand wrote:
> I'd like to apply the attached patch to php-mdb2 in Squeeze. Reasons:
> - Call by reference is deprecated in PHP 5.3 (and removed in PHP 5.4)
> - This fixes an issue in roundcube, which is widely used (especially the
> backports, which I also use in production)
> - This is a very small patch, which can't hurt anything. Call-time
> pass-by-reference is well documented, just removing the "&" solves it,
> and I don't think a mistake is possible.
> - Teodor MICU <mteodor@gmail.com> tested it, and me as well in production.
> - The same kind of fix is already in SID (modified upstream in the same
> way as the attached patch), with so far no problems reported upstream or
> in the Debian BTS.
The patch must be minimal. Gracious variable name changing isn't. php5 in
squeeze is 5.3. The normal way to fix a backport to work correctly would be to
backport the lib in question. I'm very vary if that thing by itself is
suitable to trigger an update in stable.
I am wondering what use deprecation warnings have in a production release,
though. Especially if they're turned on by default. (Surely you wouldn't want
them in production use after all!?) Python got rid of them, IIRC.
Kind regards
Philipp Kern
Reply to: