[Jonathan Nieder, 2012-12-09] > [...] > > --- python-defaults-2.7.3~rc2/debian/pyversions.py 2012-06-05 22:58:56.000000000 -0400 > > +++ python-defaults-2.7.3/debian/pyversions.py 2012-07-26 18:26:10.000000000 -0400 > > @@ -110,7 +110,8 @@ > > else: > > return _unsupported_versions > > > > -_supported_versions = None > > +_supported_versions = ["python%s" % ver for ver in \ > > + os.environ.get('DEBPYTHON_SUPPORTED', '').split()] > > That's > > * pyversions, dh_python2, pycompile: allow to override system's list of > supported Python versions via DEBPYTHON_SUPPORTED and default Python > version via DEBPYTHON_DEFAULT env. variables > > Do any packages in wheezy use these envvars? What will happen if they > are rebuilt against python-defaults from wheezy? packages are not using it yet. Once they do, they should use it for tests only. Wheezy administrators will be able to easily re-add support for Python 2.4 thanks to these envvars (rebuilding one package to add 2.4 symlinks should be much easier and safer with envvar than with changing list of supported versions system-wide) > > --- python-defaults-2.7.3~rc2/debpython/pydist.py 2012-06-05 22:58:56.000000000 -0400 > > +++ python-defaults-2.7.3/debpython/pydist.py 2012-07-26 18:26:10.000000000 -0400 > [...] > > @@ -41,7 +42,7 @@ > > ;\s* > > (?P<standard>PEP386)? # PEP-386 mode > > \s* > > - (?P<rules>s/.*)? # translator rules > > + (?P<rules>(?:s|tr|y).*)? # translator rules > > )? > > Do source packages in wheezy use this feature? no (sadly, it looks like I'm the only one who includes *.pydist files in packages) > [...] > > --- python-defaults-2.7.3~rc2/Makefile 2012-06-05 22:58:56.000000000 -0400 > > +++ python-defaults-2.7.3/Makefile 2012-07-26 18:26:10.000000000 -0400 > > @@ -30,6 +30,9 @@ > > %.1: %.rst > > rst2man $< > $@ > > > > +%.html: %.rst > > + rst2html $< > $@ > > Doesn't seem necessary for wheezy. it's not used at build time > [...] > > --- python-defaults-2.7.3~rc2/pydist/dist_fallback 2012-06-05 22:58:56.000000000 -0400 > > +++ python-defaults-2.7.3/pydist/dist_fallback 2012-07-26 18:26:10.000000000 -0400 > > @@ -2,7 +2,9 @@ > > setuptools python-pkg-resources > > wsgiref python (>= 2.5) | python-wsgiref > > argparse python (>= 2.7) | python-argparse > > +pil python-imaging > > AddOns python-peak.util > > +BatchModify trac-batchmodify > [etc] > > --- python-defaults-2.7.3~rc2/pydist/generate_fallback_list.py 2012-06-05 22:58:56.000000000 -0400 > > +++ python-defaults-2.7.3/pydist/generate_fallback_list.py 2012-07-26 18:26:10.000000000 -0400 > > @@ -72,4 +72,6 @@ > > fp.write('setuptools python-pkg-resources\n') > > fp.write('wsgiref python (>= 2.5) | python-wsgiref\n') > > fp.write('argparse python (>= 2.7) | python-argparse\n') > > +# wasn't recognized due to .pth file (egg-info is in PIL/ and not in *-packages/) > > +fp.write('pil python-imaging\n') > > Am I correct in guessing these are needed in wheezy? yes, at least one package was depending on the pil line, the rest is just an update (fallback list is not generated at every build as it requires network connection to download Contents file) [...] > Thanks for including tests along with the fixes. \o/ you should see what SQLAlchemy author does - there are over 100 KiB of pure Python unit tests (for almost every bug reported) in sqlalchemy 0.7.9 (for which I still didn't send unblock request - I'll do it once 0.6.9 update for Squeeze is ready - I will need to convince you upstream author is very sane in both cases) -- Piotr Ożarowski Debian GNU/Linux Developer www.ozarowski.pl www.griffith.cc www.debian.org GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645
Attachment:
signature.asc
Description: Digital signature