Bug#693387: Pre-approval for unblock: sysvinit/2.88dsf-33
On Fri, Nov 16, 2012 at 02:11:13AM +0100, Michael Biebl wrote:
> On 16.11.2012 01:48, Michael Biebl wrote:
> > On 15.11.2012 23:32, Roger Leigh wrote:
> >> Package: release.debian.org
> >> Severity: normal
> >> User: release.debian.org@packages.debian.org
> >> Usertags: unblock
> >>
> >> Please unblock package sysvinit
> >>
> >> The attached debdiff includes a correction to the init script
> >> dependencies for the three bootclean scripts. (#677097)
> >
> > Why did you choose to not simply add mountall-bootclean to $local_fs?
> >
>
> As already mentioned on IRC: checkroot-bootclean is kinda odd.
> It cleans up /run/, /run/lock *after* the tmpfs has been mounted, so
> this cleanup looks entirely pointless.
The main point of this script was to clean /tmp prior to mounting a
tmpfs, as well as /lib/init/rw (for historical reasons). It also
handles cleaning of /run and /run/lock; for platforms which don't
support a tmpfs, or where the admin has explicitly disabled tmpfs
mounting.
> An for cleaning up /tmp in checkroot-bootclean: Since the goal here is
> to cleanup /tmp before it is later shadowed by a mount (via mountall),
> the mountall script should have a dependency on checkroot-bootclean.
> Otherwise it can happen that you mount /tmp while the cleanup is still
> running. Or am I missing something?
No, I think you're correct. This also needs a dependency.
Required-Start: checkroot-bootclean
in mountall should address this.
Regards,
Roger
--
.''`. Roger Leigh
: :' : Debian GNU/Linux http://people.debian.org/~rleigh/
`. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools
`- GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
Reply to: