[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#692784: marked as done (unblock: ircd-ircu/2.10.12.10.dfsg1-1.1)

Your message dated Thu, 08 Nov 2012 20:02:14 +0000
with message-id <1352404934.20648.8.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#692784: unblock: ircd-ircu/2.10.12.10.dfsg1-1.1
has caused the Debian Bug report #692784,
regarding unblock: ircd-ircu/2.10.12.10.dfsg1-1.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
692784: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692784
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-CC: ircd-ircu@packages.debian.org

Please unblock package ircd-ircu. The version currently in sid fixes RC
bug #689893. The debdiff is attached.

unblock ircd-ircu/2.10.12.10.dfsg1-1.1

Thanks,

diff -u ircd-ircu-2.10.12.10.dfsg1/debian/dirs ircd-ircu-2.10.12.10.dfsg1/debian/dirs
--- ircd-ircu-2.10.12.10.dfsg1/debian/dirs
+++ ircd-ircu-2.10.12.10.dfsg1/debian/dirs
@@ -4 +3,0 @@
-var/run/ircd
diff -u ircd-ircu-2.10.12.10.dfsg1/debian/changelog ircd-ircu-2.10.12.10.dfsg1/debian/changelog
--- ircd-ircu-2.10.12.10.dfsg1/debian/changelog
+++ ircd-ircu-2.10.12.10.dfsg1/debian/changelog
@@ -1,3 +1,12 @@
+ircd-ircu (2.10.12.10.dfsg1-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  
+  [ Thomas Goirand ]
+  * Fixes handling of /var/run/ircd life cycle (Closes: #689893, LP: #369115).
+
+ -- Sébastien Villemot <sebastien@debian.org>  Mon, 05 Nov 2012 20:04:25 +0100
+
 ircd-ircu (2.10.12.10.dfsg1-1) unstable; urgency=low
 
   * The "Omertà" release
diff -u ircd-ircu-2.10.12.10.dfsg1/debian/rules ircd-ircu-2.10.12.10.dfsg1/debian/rules
--- ircd-ircu-2.10.12.10.dfsg1/debian/rules
+++ ircd-ircu-2.10.12.10.dfsg1/debian/rules
@@ -92,7 +92,6 @@
 
 	# fix directory permissions for logdir
 	chown -R irc:irc debian/ircd-ircu/var/log/ircd
-	chown -R irc:irc debian/ircd-ircu/var/run/ircd
 
 	# move manpage
 	mv debian/ircd-ircu/usr/share/man/man8/ircd.8 debian/ircd-ircu/usr/share/man/man8/ircd-ircu.8
diff -u ircd-ircu-2.10.12.10.dfsg1/debian/init ircd-ircu-2.10.12.10.dfsg1/debian/init
--- ircd-ircu-2.10.12.10.dfsg1/debian/init
+++ ircd-ircu-2.10.12.10.dfsg1/debian/init
@@ -22,7 +22,15 @@
           
 # where the irc-daemon is
 IRCD=/usr/sbin/ircd-ircu
-PIDFILE=/var/run/ircd/ircd.pid                  
+RUNDIR=/var/run/ircd
+PIDFILE=${RUNDIR}/ircd.pid                  
+
+if [ ! -d ${RUNDIR} ] ; then
+	mkdir -p ${RUNDIR} || true
+	if [ -d ${RUNDIR} ] ; then
+		chown -R irc:irc ${RUNDIR}
+	fi
+fi
 
 if [ -x "$IRCD" ]; then
   case "$1" in

-- 
 .''`.    Sébastien Villemot
: :' :    Debian Developer
`. `'     http://www.dynare.org/sebastien
  `-      GPG Key: 4096R/381A7594

Attachment: pgplRvmtccr9J.pgp
Description: PGP signature


--- End Message ---
--- Begin Message --- 
On Thu, 2012-11-08 at 20:26 +0100, Sébastien Villemot wrote:
> Please unblock package ircd-ircu. The version currently in sid fixes RC
> bug #689893. The debdiff is attached.

+ if [ ! -d ${RUNDIR} ] ; then
+         mkdir -p ${RUNDIR} || true
+         if [ -d ${RUNDIR} ] ; then
+                 chown -R irc:irc ${RUNDIR}
+         fi
+ fi

This seems either overly complicated or not complicated enough. If the
"mkdir -p" fails then the s-s-d call is presumably going to fail in any
case, so the "|| true" and later -d are somewhat redundant.

otoh, it's better than the current package and if the mkdir fails then a
bunch of other stuff on the system will be broken; unblocked.

Regards,

Adam

--- End Message ---
Reply to: