Bug#689147: unblock: gajim/0.15.1-1
On 10/12/2012 11:31 AM, Julien Cristau wrote:
On Sat, Sep 29, 2012 at 16:12:55 +0200, Yann Leboulanger wrote:
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package gajim
A new Gajim release fixes some bugs, and particulary the bug #682598 [0]
More information can be found in the Mail I sent to debian-release mailing
list: [1]
debdif is available here: [2]
[0]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682598
[1]: http://lists.debian.org/debian-release/2012/09/msg00042.html
[2]: http://lagaule.org/debian/gajim/gajim-0.15.1.debdiff
unblock gajim/0.15.1-1
A few comments:
- the source format change is not appropriate
It's because it was in format 3.0 previously (Gajim 0.14.4), and for
0.15 I did something wrong that I wanted to repair. Moreover, I need to
add a patch for your next point (change to _StreamCB) and it's nicer in
format 3.0. If you really want, I can re-do the patch in old format.
- why does this drop the 0.15-1.1 changelog entry?
hmm I didn't do this upload so it was not in my debian files. I've
re-added it.
- what does the src/common/check_X509.py change do? string comparison
and version comparison are kind of different things...
Gajim 0.15 badly checks openssl version. see
https://trac.gajim.org/ticket/7124
- how is the change to _StreamCB supposed to work? there doesn't seem
to be an 'obj' variable in that function
It does not work. Oauth2 is not in 0.15 branch, so not usefull. But ok,
I've added a patch to remove that.
- the src/common/gnupg.py changes are big and don't really look bugfix
only. What's the potential for regression there?
gnupg.py is an external library that is not yet packaged, it's why it is
in Gajim sources (it's in Gajim repos too). I've take the new release
from there. It's in Gajim trunk since May, 18, and don't cause any trouble.
Of course I've read the changes, and I don't see anything that could
cause a problem.
Overall I think I'm ok with the farstream/farsight change but I'm not so
sure about the rest. At least without some more explanations why
they're necessary.
Thanks for the comments, I hope I explained what you wanted to know,
else don't hesitate to ask.
I've re-build a new package available here:
http://lagaule.org/debian/gajim/
I'll ask a debian developper to upload it as soon as you tell me it's ok
(or you prefer it to be uploaded now? )
--
Yann
Reply to: