On Sat, Sep 29, 2012 at 16:12:55 +0200, Yann Leboulanger wrote: > Package: release.debian.org > Severity: normal > User: release.debian.org@packages.debian.org > Usertags: unblock > > Please unblock package gajim > > A new Gajim release fixes some bugs, and particulary the bug #682598 [0] > More information can be found in the Mail I sent to debian-release mailing > list: [1] > debdif is available here: [2] > > [0]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682598 > [1]: http://lists.debian.org/debian-release/2012/09/msg00042.html > [2]: http://lagaule.org/debian/gajim/gajim-0.15.1.debdiff > > unblock gajim/0.15.1-1 > A few comments: - the source format change is not appropriate - why does this drop the 0.15-1.1 changelog entry? - what does the src/common/check_X509.py change do? string comparison and version comparison are kind of different things... - how is the change to _StreamCB supposed to work? there doesn't seem to be an 'obj' variable in that function - the src/common/gnupg.py changes are big and don't really look bugfix only. What's the potential for regression there? Overall I think I'm ok with the farstream/farsight change but I'm not so sure about the rest. At least without some more explanations why they're necessary. Cheers, Julien
Attachment:
signature.asc
Description: Digital signature