[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#681233: unblock: pynn/0.7.4-1



Hi Yaroslav,

On 22 août 12, at 18:08, Yaroslav Halchenko wrote:
unblocked anyway...

thanks Julien!  you made me blush that I have missed them in my
quick review of the changes.

NB I am CCing upstream who might like to straighten those up

On Wed, 22 Aug 2012, Julien Cristau wrote:
def setup(timestep=0.1, min_delay=0.1, max_delay=0.1, debug=False,**extra_params):
+
+ logger.debug("setup() called, extra_params = "+str(extra_params))

this is broken, surely it should be below the docstring?

ideally -- yes -- but should be harmless

    """
    Should be called at the very beginning of a script.
extra_params contains any keyword arguments that are required by a given
    simulator but not by others.
    """


also the sys.path.append('/usr/lib/python2.x/site-packages/oldxml')
seems like a horrible, horrible hack.

indeed... with not 100% clear motive (besides suggesting wanting
an older xml module, which was just bluntly manually copied on
that system).

Andrew -- could you clarify?:

src/neuroml.py:sys.path.append('/usr/lib/python%s/site-packages/ oldxml' % sys.version[:3]) # needed for Ubuntu src/neuroml2.py:sys.path.append('/usr/lib/python%s/site-packages/ oldxml' % sys.version[:3]) # needed for Ubuntu

may be those are just left-overs which could be safely dropped?

These two files (neuroml.py and neuroml2.py) are experimental code, and are not intended to be distributed with PyNN 0.7.x (they will be cleaned up and tested for the upcoming PyNN 0.8.0)

I can edit the MANIFEST.in file to specifically exclude them, and make a bug-fix release 0.7.5, but this seems like overkill. Is it necessary?

Best regards, and many thanks again for your work on this,

Andrew


--
Dr Andrew Davison
Unité de Neuroscience, Information et Complexité (UNIC)
Institut de Neurobiologie Alfred Fessard
Centre Nationale de la Recherche Scientifique
1, avenue de la Terrasse
91198 Gif sur Yvette
France

Tel: +33 1 69 82 34 51
http://www.andrewdavison.info/


Reply to: