[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#681233: unblock: pynn/0.7.4-1



> unblocked anyway...

thanks Julien!  you made me blush that I have missed them in my
quick review of the changes.

NB I am CCing upstream who might like to straighten those up

On Wed, 22 Aug 2012, Julien Cristau wrote:
> >  def setup(timestep=0.1, min_delay=0.1, max_delay=0.1, debug=False,**extra_params):
> > +
> > +    logger.debug("setup() called, extra_params = "+str(extra_params))

> this is broken, surely it should be below the docstring?

ideally -- yes -- but should be harmless

> >      """
> >      Should be called at the very beginning of a script.
> >      extra_params contains any keyword arguments that are required by a given
> >      simulator but not by others.
> >      """


> also the sys.path.append('/usr/lib/python2.x/site-packages/oldxml')
> seems like a horrible, horrible hack.

indeed... with not 100% clear motive (besides suggesting wanting
an older xml module, which was just bluntly manually copied on
that system).

Andrew -- could you clarify?:

src/neuroml.py:sys.path.append('/usr/lib/python%s/site-packages/oldxml' % sys.version[:3]) # needed for Ubuntu
src/neuroml2.py:sys.path.append('/usr/lib/python%s/site-packages/oldxml' % sys.version[:3]) # needed for Ubuntu

may be those are just left-overs which could be safely dropped?

-- 
Yaroslav O. Halchenko
Postdoctoral Fellow,   Department of Psychological and Brain Sciences
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik        


Reply to: