[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#685851: marked as done (unblock: approx/5.3-1)

Your message dated Sun, 26 Aug 2012 03:28:22 +0200
with message-id <20120826012822.GH19361@mraw.org>
and subject line Re: Bug#685851: unblock: approx/5.3-1
has caused the Debian Bug report #685851,
regarding unblock: approx/5.3-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
685851: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=685851
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package approx.

Version 5.3-1 fixes important bug #685724, and requires only a
one-line fix (debdiff attached).  Thanks for considering this.

unblock approx/5.3-1

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing'), (400, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru approx-5.2/approx.ml approx-5.3/approx.ml
--- approx-5.2/approx.ml	2012-04-30 17:35:11.000000000 -0400
+++ approx-5.3/approx.ml	2012-08-24 14:55:52.000000000 -0400
@@ -1,5 +1,5 @@
 (* approx: proxy server for Debian archive files
-   Copyright (C) 2011  Eric C. Cooper <ecc@cmu.edu>
+   Copyright (C) 2012  Eric C. Cooper <ecc@cmu.edu>
    Released under the GNU General Public License *)
 
 open Printf
@@ -180,7 +180,7 @@
   | Cache { file = file; tmp_file = tmp_file; chan = chan } ->
       debug_message "  close cache %s" file;
       close_out chan;
-      if size = file_size tmp_file then begin
+      if size = -1L or size = file_size tmp_file then begin
         if mod_time <> 0. then begin
           debug_message "  setting mtime to %s" (Url.string_of_time mod_time);
           utimes tmp_file mod_time mod_time
diff -Nru approx-5.2/config.ml approx-5.3/config.ml
--- approx-5.2/config.ml	2012-05-01 17:52:33.000000000 -0400
+++ approx-5.3/config.ml	2012-08-24 14:55:52.000000000 -0400
@@ -5,7 +5,7 @@
 open Config_file
 open Util
 
-let version = "5.2"
+let version = "5.3"
 
 let default_config = "/etc/approx/approx.conf"
 
diff -Nru approx-5.2/debian/changelog approx-5.3/debian/changelog
--- approx-5.2/debian/changelog	2012-05-23 16:04:58.000000000 -0400
+++ approx-5.3/debian/changelog	2012-08-24 14:58:18.000000000 -0400
@@ -1,3 +1,11 @@
+approx (5.3-1) unstable; urgency=low
+
+  * New upstream version
+  * Check for chunked transfer encoding when closing cache file
+    (closes: #685724)
+
+ -- Eric Cooper <ecc@cmu.edu>  Fri, 24 Aug 2012 14:56:45 -0400
+
 approx (5.2-1) unstable; urgency=low
 
   [ Eric Cooper ]

--- End Message ---
--- Begin Message --- 
Hi Eric,

Eric Cooper <ecc@cooper-siegel.org> (25/08/2012):
> Please unblock package approx.
> 
> Version 5.3-1 fixes important bug #685724, and requires only a
> one-line fix (debdiff attached).  Thanks for considering this.
> 
> unblock approx/5.3-1

looks good to me, unblocked. A little note however:

> diff -Nru approx-5.2/approx.ml approx-5.3/approx.ml
> --- approx-5.2/approx.ml	2012-04-30 17:35:11.000000000 -0400
> +++ approx-5.3/approx.ml	2012-08-24 14:55:52.000000000 -0400
> @@ -1,5 +1,5 @@
>  (* approx: proxy server for Debian archive files
> -   Copyright (C) 2011  Eric C. Cooper <ecc@cmu.edu>
> +   Copyright (C) 2012  Eric C. Cooper <ecc@cmu.edu>
>     Released under the GNU General Public License *)

Maybe you want that instead:
   Copyright (C) 2011-2012  Eric C. Cooper <ecc@cmu.edu>

Thanks for the (really targeted) bug fix.

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: