[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#685670: Doesn't use build flags



Hello,

Eugene V. Lyubimkin <jackyf@debian.org> (25/08/2012):
> Hello Felix (and debian-release@, BCC'ed)

(cc'd this time, so that others see my reply.)

> On 2012-08-23 10:39, Felix Geyer wrote:
> > Source: htop
> > Version: 1.0.1-1
> > Severity: important
> > 
> > htop doesn't export any build flags so it's built without
> > optimizations, debugging symbols and hardening options.
> 
> Thank you for the report. The package was forgotten to be adapted for
> the new incompatible dpkg environment variables export rules months ago.
> 
> Htop is not CPU-bound neither a subject for great security risks, still
> would be nice to fix. A fix however includes changing the build flags,
> not a small change considering the freeze.
> 
> So, dear Release Team: would you like to have this bug fixed in Wheezy?

IMVHO, fixing the optimization+debug flags issue would look nice to me,
while hardening flags would just be a bonus. Adding to debian/rules:
  CFLAGS = $(shell dpkg-buildflags --get CFLAGS)

would fix this, keeping the diff short, and it shouldn't be a problem to
unblock that kind of fix.

Changing debhelper compat and the like isn't exactly something we like
at this point, though.

On a side note, I see, still in debian/rules:
  CFLAGS="$(CFLAGS)" LDFLAGS="$(INSTALL_PROGRAM)" ./configure […]

Is INSTALL_PROGRAM really what you wanted here or is that a typo?

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: