[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#684007: unblock: ukolovnik/1.4-1



Hi

Dne Mon, 6 Aug 2012 23:31:12 +0200
Cyril Brulebois <kibi@debian.org> napsal(a):

> Michal Čihař <nijel@debian.org> (06/08/2012):
> > The only important change it brings are new translations. Besides that
> > it fixes few tiny errors (possibly unset variables and checking if
> > locales are present), see attached diff for code changes.
> 
> I think I could understand the logic behind setting $oldcategory to
> null, 

It is name of previous category used for grouping. Before entering
while loop this was previously unset causing PHP warning.

> but I'm not sure why the $filter goes away entirely? Maybe it was
> unset? (Not clear from the diff.)

It was not used (and set) at all in this code path.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

Attachment: signature.asc
Description: PGP signature


Reply to: