[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#684007: unblock: ukolovnik/1.4-1



Michal Čihař <nijel@debian.org> (06/08/2012):
> The only important change it brings are new translations. Besides that
> it fixes few tiny errors (possibly unset variables and checking if
> locales are present), see attached diff for code changes.

I think I could understand the logic behind setting $oldcategory to
null, but I'm not sure why the $filter goes away entirely? Maybe it was
unset? (Not clear from the diff.)

> --- ukolovnik-1.3/index.php	2010-10-06 17:00:03.000000000 +0200
> +++ ukolovnik-1.4/index.php	2012-08-06 10:39:27.000000000 +0200
> @@ -757,7 +758,7 @@
>              header('Content-Type: text/plain; charset=utf-8');
>              header('Content-Disposition: attachment; filename="ukolovnik.csv"');
>  
> -            $q = SQL_do('SELECT id,category,UNIX_TIMESTAMP(created) AS created,priority,title,description,UNIX_TIMESTAMP(closed) AS closed FROM ' . $GLOBALS['table_prefix'] . 'tasks ' . $filter . ' ORDER BY priority DESC, created ASC');
> +            $q = SQL_do('SELECT id,category,UNIX_TIMESTAMP(created) AS created,priority,title,description,UNIX_TIMESTAMP(closed) AS closed FROM ' . $GLOBALS['table_prefix'] . 'tasks ORDER BY priority DESC, created ASC');
>              echo "priority,title,description,category,created,closed\n";
>              if (mysql_num_rows($q) > 0) {
>                  while ($row = mysql_fetch_assoc($q)) {

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: