[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#661078: britney: ignore additional packages in Sources index



On 2012-02-24 01:22, Ansgar Burchardt wrote:
> Package: release.debian.org
> Severity: wishlist
> User: release.debian.org@packages.debian.org
> Usertags: britney
> 
> I would like to include additional packages referenced by Built-Using in
> the Sources index[1] at some undefined point in the future.  This might
> confuse britney which would need to just ignore them.
> 
> Ansgar
> 
> [1] <http://bugs.debian.org/657212>
> 
> 
> 

Hi,

In light of our IRC chat in #d-ftp today and the asumption that the
"Only-Extra-Source" field will be implemented, I believe I have a
trivial patch that will work[1].  There is an updated test for it in the
"britney2-tests"[2] (the new repository announced today - not the old one).
  The patch is backwards compatible and could be applied before the
extra sources appear in the Sources files (and without updating any of
the unrelated existing tests).

It is my understanding that the new field has only been proposed at this
point, but the field would greatly simplify the Britney changes and keep
the risks of regressions at a minimal.

~Niels

[1]
http://anonscm.debian.org/gitweb/?p=users/nthykier/britney.git;a=shortlog;h=refs/heads/bug-661078

(also attached)

[2] http://anonscm.debian.org/gitweb/?p=collab-maint/britney2-tests.git

>From 9c3622ece11b53467c33bc1dab2dfa5c3216aebe Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels@thykier.net>
Date: Fri, 29 Jun 2012 23:23:25 +0200
Subject: [PATCH] Ignore sources only referenced by Built-Using

Signed-off-by: Niels Thykier <niels@thykier.net>
---
 britney.py |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/britney.py b/britney.py
index 5205f64..e3e1cdb 100755
--- a/britney.py
+++ b/britney.py
@@ -453,6 +453,9 @@ class Britney(object):
         step = Packages.step
 
         while step():
+            if get_field('Only-Extra-Source', 'no') == 'yes':
+                # Ignore sources only referenced by Built-Using
+                continue
             pkg = get_field('Package')
             ver = get_field('Version')
             # There may be multiple versions of the source package
-- 
1.7.10


Reply to: