Re: Fwd: Bug#647563: laptop-mode-tools: incompatible with linux 3.0 and later

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

On Sun, 2012-02-05 at 12:31 +0530, Ritesh Raj Sarraf wrote:
> On Sunday 05 February 2012 02:56 AM, Henrique de Moraes Holschuh wrote:
> > On Sun, 05 Feb 2012, Ritesh Raj Sarraf wrote:
> >> >  Please review the attached diff. This change will fix bug 647563.
> 
> > Looks like /usr/share/laptop-mode-tools/modules/laptop-mode also need
> > fixing...
> 
> Yes. Thanks for catching that. Attached diff fixes it.

Thanks for the diff.

I'm guessing there's been a copy-n-waste error.  Diffing the old and new
"enable" sections looks wrong:

+-                      log "VERBOSE" "Adjusting 2.6 kernel parameters to enable laptop mode."
+-                      set_sysctl /proc/sys/vm/laptop_mode               "$LM_SECONDS_BEFORE_SYNC"
+-                      set_sysctl /proc/sys/vm/dirty_writeback_centisecs "$AGE"
+-                      set_sysctl /proc/sys/vm/dirty_expire_centisecs    "$AGE"
[...]
++                log "VERBOSE" "Adjusting 2.6+ kernel parameters to disable laptop mode."
++                set_sysctl /proc/sys/vm/dirty_writeback_centisecs   "$U_AGE"
++                set_sysctl /proc/sys/vm/dirty_expire_centisecs      "$B_AGE"

Regards,

Adam