Re: Bug#653053: ldap2zone: Sending email every hour fill up the mail spool
On 25.12.2011 09:16, Petter Reinholdtsen wrote:
A fix in lpad2zone has been implemented in unstable, where printing
to
stdout has been replaced with logging to syslog. I would very much
like
to have the same change in Squeeze, and thus ask for permission from
the
release managers before uploading to proposed-updates. What version
number do you recommend to use for this version?
<current stable>+squeeze1 would be conventional, where there's no
current +squeezeX in stable.
+ * Backport fix from 2.2-2: Made script log using logger by a
+ patch contributed by Petter Reinholdtsen (Closes: #653053).
[...]
diff -u
ldap2zone-0.1/debian/patches/05_correct_bashisms_ldap2bind.dpatch
ldap2zone-0.1/debian/patches/05_correct_bashisms_ldap2bind.dpatch
--- ldap2zone-0.1/debian/patches/05_correct_bashisms_ldap2bind.dpatch
+++ ldap2zone-0.1/debian/patches/05_correct_bashisms_ldap2bind.dpatch
What does the proposed change have to do with fixing bashisms?
@@ -27,7 +27,7 @@
if [ $? -ne 0 ]; then
- echo -e "Reloading the zone '$domain' failed:\n$result" 1>&2
-+ printf "Reloading the zone '$domain' failed: $result\n" 1>&2
++ logger -t ldap2bind "Reloading the zone '$domain' failed:
$result\n" 1>&2
+ else
-+ printf "Reloading the zone '$domain' was successful\n" 1>&2
++ logger -t ldap2bind "Reloading the zone '$domain' was
successful\n" 1>&2
fi
I have to admit that my first thought here was much the same as
Julien's - if the problem is that mail is being sent on the successful
completion of a job which is expected to succeed, why is a change also
being made to the failure path?
Regards,
Adam
Reply to: