Re: Stable update for gdm3

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

On Thu, 2011-08-18 at 18:48 +0200, Josselin Mouette wrote:
> please find attached a proposed stable update for gdm3.

Thanks for working on this.

> gdm3 (2.30.5-6squeeze4) stable; urgency=low
> 
>   * 35_double_free.patch: stolen from 2.30.7. Fix a double free issue in 
>     the chooser code.
>   * 36_windowpath.patch: stolen from 2.30.7. Only set the WINDOWPATH 
>     variable if not null.
>   * 37_shutdown_buttons.patch: stolen from upstream git. Only show 
>     shutdown options when requested. Closes: #628032.

These all look fine in their own right, but it doesn't look like they
have been applied to the package in unstable, as far as I can tell?  If
that's the case, please apply them there first.

>   * 14_pam_dialog.patch: remove the beep, since it happens after the 
>     session has been reaped and can lock the sound device.

Either I'm being stupid or this patch is broken.  Quite happy to have it
proven to be the former. :)

--- gdm3-2.30.5/debian/patches/14_pam_dialog.patch      2011-04-20 21:28:24.000000000 +0200
+++ gdm3-2.30.5/debian/patches/14_pam_dialog.patch      2011-08-18 18:21:18.000000000 +0200
[...]
+@@ -667,8 +667,65 @@ gdm_greeter_login_window_problem (GdmGre
  
          g_debug ("GdmGreeterLoginWindow: problem: %s", text);
  
 -        set_message (GDM_GREETER_LOGIN_WINDOW (login_window), text);
+-        gdk_window_beep (GTK_WIDGET (login_window)->window);
 +        _gdm_greeter_login_window_set_interactive (login_window, FALSE);

The _beep() call being removed there doesn't appear to be in the version
of gdm-greeter-login-window.c in the current squeeze package.

 +
-         gdk_window_beep (GTK_WIDGET (login_window)->window);

and this version is still present in the corresponding patch in
unstable.

Regards,

Adam