Bug#630251: patch for proposed updates / rdesktop sometimes fails to transfer files from win2k8
clone 630251 -1
retitle -1 rdesktop: value for CallerAvailableAllocationUnits from FileFsFullSizeInformation is too high
reassign -1 rdesktop 1.7.0-1
tags -1 = upstream
quit
Hi Laszlo,
Laszlo Boszormenyi wrote:
> On Mon, 2011-06-13 at 20:48 +0100, Adam D. Barratt wrote:
>> This is nearly, but not quite, the same as the corresponding code in the
>> current rdesktop package in unstable. Other than the printf(), the
>> difference is that where the proposed fix has:
[...]
>>> + out_uint32_le(out, stat_fs.f_bavail); /* CallerAvailableAllocationUnits */
[...]
>> the package in unstable has:
[...]
>> out_uint32_le(out, stat_fs.f_blocks); /* Caller allocation units low */
[...]
> IMHO the former one is the correct, the changes in unstable seem to
> have a copy&paste bug. stat_fs.f_blocks may has nothing to do with
> 'caller allocation units low'. Will ask upstream soon.
FWIW I also suspect that Jean-Michel's patch was correct and the patch
applied upstream contains a typo. disk.c in the upstream svn repo
looks the same as sid. Cloning to track this.
Reply to: