Re: Add support for XMLRPC v31 in Pianobar
On Tue, Aug 16, 2011 at 15:59, Adam D. Barratt <adam@adam-barratt.org.uk> wrote:
>> No new functionality was introduced (and no APIs used by pianobar were
>> modified), only API keys needed to be updated (an additional field was
>> added to the API, but it is not currently used).
>
> Apologies if I'm missing something but you say "only API keys needed to
> be updated", but the diff doesn't appear to include any such changes.
>
> (Aside from which, an enforced API bump for a field which currently has
> no purpose seems somewhat silly)
No, you're not. I was thinking of the previous API bump, v30. My mind
must be going.
The v31 bump does in fact serve no functional purpose, but sadly
Pandora has shown they don't care about API compatibility. (since
their API is entirely undocumented, this makes sense from their
perspective)
>> A patch is attached
>> which includes all changes which would need to be made.
>
> Out of interest, why does the changelog only mention the Launchpad bug,
> not the corresponding entry in the Debian BTS - particularly given that
> the upload to unstable included both?
I added the BTS reference after making the diff, but then did not
remake the diff.
Out of curiosity, is it generally preferred to ask before uploading?
If an upload is made in error or needs additional work, it can always
be removed from the queue, no?
--
Luke Faraone;; Debian & Ubuntu Developer; Sugar Labs, Systems
lfaraone on irc.[freenode,oftc].net -- http://luke.faraone.cc
PGP fprint: 5189 2A7D 16D0 49BB 046B DC77 9732 5DD8 F9FD D506
Reply to: