[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#630044: transition: poppler 0.16



Am 29.06.2011 19:11, schrieb Philipp Kern:
> Hi,
> 
> the only issue I see at the moment is this:
> 
> On Fri, Jun 10, 2011 at 05:03:47PM +0200, Pino Toscano wrote:
>> * python-poppler (poppler-glib)
>>     The (small) patch needed to compile with poppler 0.16 is not
>>     compatible with poppler 0.12, so it cannot be uploaded right now.
>>     Asked to provide a version in experimental compilable with poppler
>>     0.16, see #628047.
> 
> There's a claim at the LP bug[1] that the patch isn't suitable.  From a casual
> look that comment seems wrong, but you can judge this better than me.
> 
> If that's resolved I'm ok with you going ahead with this transition.  Please
> ping me when it's uploaded, though, so that I can take care of the binNMUs.
> 
> Kind regards
> Philipp Kern
> 
> [1] https://bugs.launchpad.net/poppler-python/+bug/696025

Jakub mentioned on irc that the patch in [1] is wrong.
There's an alternate patch shipped in the fedora package.

I've attached this patch and hope the more python/poppler savvy people can take
a look at it.

Cheers,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff -up pypoppler-0.12.1/poppler.defs.poppler15 pypoppler-0.12.1/poppler.defs
--- pypoppler-0.12.1/poppler.defs.poppler15	2010-10-06 16:02:47.023101009 -0400
+++ pypoppler-0.12.1/poppler.defs	2010-10-06 16:10:32.749101000 -0400
@@ -1760,6 +1760,12 @@
   (return-type "int")
 )
 
+(define-method get_label
+  (of-object "PopplerPage")
+  (c-name "poppler_page_get_label")
+  (return-type "gchar*")
+)
+
 (define-method get_duration
   (of-object "PopplerPage")
   (c-name "poppler_page_get_duration")
@@ -1805,9 +1811,15 @@
   (of-object "PopplerPage")
   (c-name "poppler_page_get_text")
   (return-type "char*")
+)
+
+(define-method get_selected_text
+  (of-object "PopplerPage")
+  (c-name "poppler_page_get_selected_text")
+  (return-type "char*")
   (parameters
     '("PopplerSelectionStyle" "style")
-    '("PopplerRectangle*" "rect")
+    '("PopplerRectangle*" "selection")
   )
 )
 
@@ -1895,6 +1907,16 @@
   )
 )
 
+(define-function poppler_page_add_annot
+  (of-object "PopplerPage")
+  (c-name "poppler_page_add_annot")
+  (return-type "none")
+  (parameters
+    '("PopplerAnnot*" "annot")
+    '("GList*" "list")
+  )
+)
+
 (define-method get_crop_box
   (of-object "PopplerPage")
   (c-name "poppler_page_get_crop_box")
@@ -1904,6 +1926,16 @@
   )
 )
 
+(define-method get_text_layout
+  (of-object "PopplerPage")
+  (c-name "poppler_page_get_text_layout")
+  (return-type "gboolean")
+  (parameters
+    '("PopplerRectangle**" "rectangles")
+    '("guint*" "n_rectangles")
+  )
+)
+
 (define-function poppler_rectangle_get_type
   (c-name "poppler_rectangle_get_type")
   (return-type "GType")

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: