Re: Stable update of linux-2.6
- To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
- Cc: Ben Hutchings <ben@decadent.org.uk>, stable@kernel.org, Debian kernel maintainers <debian-kernel@lists.debian.org>, debian-release@lists.debian.org, "Adam D. Barratt" <adam@adam-barratt.org.uk>, paulmck@linux.vnet.ibm.com, mikey@neuling.org, benh@kernel.crashing.org, anton@samba.org, dann frazier <dannf@dannf.org>
- Subject: Re: Stable update of linux-2.6
- From: Greg KH <greg@kroah.com>
- Date: Tue, 5 Apr 2011 08:47:37 -0700
- Message-id: <[🔎] 20110405154737.GA31285@kroah.com>
- In-reply-to: <[🔎] 20110405151150.GF28246@linux.vnet.ibm.com>
- References: <1301254282.26693.661.camel@localhost> <1301437578.12508.562.camel@hathi.jungle.funky-badger.org> <1301440319.10056.13.camel@localhost> <20110330084109.GA8255@linux.vnet.ibm.com> <[🔎] 20110402172303.GB2611@dannf.org> <[🔎] 20110403075103.GB4822@linux.vnet.ibm.com> <[🔎] 20110404215755.GE3720@dannf.org> <[🔎] 20110405105133.GE28246@linux.vnet.ibm.com> <[🔎] 20110405140830.GA25671@kroah.com> <[🔎] 20110405151150.GF28246@linux.vnet.ibm.com>
On Tue, Apr 05, 2011 at 08:41:50PM +0530, Kamalesh Babulal wrote:
> * Greg KH <greg@kroah.com> [2011-04-05 07:08:30]:
>
> > On Tue, Apr 05, 2011 at 04:21:33PM +0530, Kamalesh Babulal wrote:
> > > * dann frazier <dannf@dannf.org> [2011-04-04 15:57:55]:
> > >
> > > > On Sun, Apr 03, 2011 at 01:21:03PM +0530, Kamalesh Babulal wrote:
> > > > > * dann frazier <dannf@dannf.org> [2011-04-02 11:23:03]:
> > > > >
> > > > > > 2.6.32.36 also fails to build on powerpc/SMP:
> > > > > >
> > > > > > CC arch/powerpc/kernel/crash.o
> > > > > > arch/powerpc/kernel/crash.c: In function 'crash_kexec_wait_realmode':
> > > > > > arch/powerpc/kernel/crash.c:176: error: 'paca' undeclared (first use in this function)
> > > > > > arch/powerpc/kernel/crash.c:176: error: (Each undeclared identifier is reported only once
> > > > > > arch/powerpc/kernel/crash.c:176: error: for each function it appears in.)
> > > > > > make[1]: *** [arch/powerpc/kernel/crash.o] Error 1
> > > > > > make: *** [arch/powerpc/kernel] Error 2
> > > > >
> > > > > Hi Dann,
> > > > >
> > > > > Can you please try the following patch, which adds the changes
> > > > > introduced by Kumar Gala to the commit b3df895aeb to my previous patch.
> > > >
> > > > Yep, that fixes the build.
> > > Thanks for testing.
> > > >
> > > > -dann
> > >
> > > Hi Greg,
> > >
> > > Can you please pick up the patch for 2.6.32-stable, resending the
> > > patch with some checkpatch warnings fixed.
> > >
> > > powerpc: Fix default_machine_crash_shutdown #ifdef build failure
> >
> > Is this patch upstream in Linus's tree? If so, what is the git commit
> > id? If not, why isn't it needed there?
> [...]
>
> the #ifdef CONFIG_PPC_STD_MMU_64 bits are taken from upstream commit
> b3df895aebe09 and the build failure incase of SMP=n is from the
> upstream commit c2be05481f61.
>
> Should I resend the patch in rebase format including both the commits
> id and message.
Yes, please do.
Reply to: