Re: Stable update of linux-2.6
- To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
- Cc: Ben Hutchings <ben@decadent.org.uk>, stable@kernel.org, Debian kernel maintainers <debian-kernel@lists.debian.org>, debian-release@lists.debian.org, "Adam D. Barratt" <adam@adam-barratt.org.uk>, greg@kroah.com, paulmck@linux.vnet.ibm.com, mikey@neuling.org, benh@kernel.crashing.org, anton@samba.org
- Subject: Re: Stable update of linux-2.6
- From: dann frazier <dannf@dannf.org>
- Date: Mon, 4 Apr 2011 15:57:55 -0600
- Message-id: <[🔎] 20110404215755.GE3720@dannf.org>
- In-reply-to: <[🔎] 20110403075103.GB4822@linux.vnet.ibm.com>
- References: <1301254282.26693.661.camel@localhost> <1301437578.12508.562.camel@hathi.jungle.funky-badger.org> <1301440319.10056.13.camel@localhost> <20110330084109.GA8255@linux.vnet.ibm.com> <[🔎] 20110402172303.GB2611@dannf.org> <[🔎] 20110403075103.GB4822@linux.vnet.ibm.com>
On Sun, Apr 03, 2011 at 01:21:03PM +0530, Kamalesh Babulal wrote:
> * dann frazier <dannf@dannf.org> [2011-04-02 11:23:03]:
>
> > 2.6.32.36 also fails to build on powerpc/SMP:
> >
> > CC arch/powerpc/kernel/crash.o
> > arch/powerpc/kernel/crash.c: In function 'crash_kexec_wait_realmode':
> > arch/powerpc/kernel/crash.c:176: error: 'paca' undeclared (first use in this function)
> > arch/powerpc/kernel/crash.c:176: error: (Each undeclared identifier is reported only once
> > arch/powerpc/kernel/crash.c:176: error: for each function it appears in.)
> > make[1]: *** [arch/powerpc/kernel/crash.o] Error 1
> > make: *** [arch/powerpc/kernel] Error 2
>
> Hi Dann,
>
> Can you please try the following patch, which adds the changes
> introduced by Kumar Gala to the commit b3df895aeb to my previous patch.
Yep, that fixes the build.
-dann
> powerpc: Fix default_machine_crash_shutdown #ifdef build failure
>
> Introducing #ifdef to fix the build failure caused by
> crash_kexec_wait_realmode(), with powerpc build with !SMP.
>
> Reported-by: Ben Hutchings <ben@decadent.org.uk>
> Reported-by: dann frazier <dannf@dannf.org>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> cc: Michael Neuling <mikey@neuling.org>
> cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> cc: Anton Blanchard <anton@samba.org>
> cc: Kumar Gala <galak@kernel.crashing.org>
Reply to: