[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [SRU] Updates for samba 3.5.6

On Sun, 2011-03-13 at 14:33 +0100, Christian PERRIER wrote:
> Quoting Adam D. Barratt (adam@adam-barratt.org.uk):
> > Would it be possible to have a debdiff against the current
> > proposed-updates package which includes the combined proposed changes
> > for the printing related bugs?  From a quick look through the separated
> > patches, it looks like some of them modify parts of the code touched by
> > earlier patches.  Is all of that set of patches really needed to fix the
> > issues?  It's not exactly small to review, given that today is the
> > advertised deadline for freezing 6.0.1. :-(
> The debdiff is likely to show the same. I kept the 9 upstream patches
> as they were in git, because the commit messages were clear about the
> set of patches to be all inter-related.

The series in https://attachments.samba.org/attachment.cgi?id=6274
includes 10 patches.  "[PATCH 09/10] librpc/ndr: handle NOALIGN flag for
relative pointers and alignment DATA_BLOBs" doesn't appear to be in your
proposed patch set, although the code it modifies does appear to be in
the source tree resulting from applying the remaining patches.

Is that patch definitely not required?

> Given the complexity of samba printing code (thanks to the clumsy
> printing protocol implemented in Microsoft Windows systems), I
> wouldn't advise for isolating these patches.

It's that very complexity that's making me hesitant about accepting the
patches at this late stage of the process for 6.0.1.



Reply to: