[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: S-P-U for #611820 ?

On Sun, 2011-02-13 at 21:51 +0100, Sean Finney wrote:
> On Sun, 2011-02-13 at 17:27 +0000, Adam D. Barratt wrote:
> > Thanks for your mail.  The fix from [2] looks fine, but I'm not
> > immediately clear how [1] relates to #611820; from a quick look, the
> > only part of dbconfig-common which ever uses "set -u" is the testsuite?
> i guess it's not strictly necessary, if it's a big deal i could try and
> split it out, just figured there'd be less risk of me fudging something
> up if i cherry picked the two directly.

Ah, I failed to spot that the second diff included context from the
first.  Yes, if you'd prefer to include the first set of fixes then that
would be okay (although does make the overall diff a little noisier).



Reply to: