Dear Release Team: First things first, congratulations on the release of squeeze! Great work! Second, I am proposing an an update to the atftp package for 2 important bugs that exist in the version in squeeze. The first is #609813 [1]: atftpd listens on a random port instead of the specified port in daemon mode. The second is #598474 [2]: multicast broken on kFreeBSD I am not the maintainer for atftp, but have uploaded NMUs for the package during the squeeze release cycle. I have cc:d Ludovic on all interaction and believe he may be having difficulties with email, as I received a bounce on an email concerning the upload of the 0.7.dfsg-9.3 NMU to unstable. The debdiff is attached, and I have uploaded a package built on a squeeze chroot to my p.d.o page [3]. Given the "brokenness" of atftpd in its current state in squeeze, please consider this package for stable-proposed-updates (and correspondingly, let me know if I should proceed with uploading to the archive). Thank you, tony [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=609813 [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=598474 [3] http://people.debian.org/~tmancill/atftp_0.7.dfsg-9.3~squeeze1.dsc
diff -u atftp-0.7.dfsg/tftpd.c atftp-0.7.dfsg/tftpd.c --- atftp-0.7.dfsg/tftpd.c +++ atftp-0.7.dfsg/tftpd.c @@ -256,6 +256,10 @@ if (!tftpd_port) tftpd_port = sockaddr_get_port(&sa); + else { + sa.ss_family = AF_INET; + sockaddr_set_port(&sa, tftpd_port); + } freeaddrinfo(result); } @@ -673,6 +677,9 @@ retval = ABORT; } /* connect the socket, faster for kernel operation */ + /* this is not a good idea on FreeBSD, because sendto() cannot + be used on a connected datagram socket */ +#if !defined(__FreeBSD_kernel__) if (connect(data->sockfd, (struct sockaddr *)&data->client_info->client, sizeof(data->client_info->client)) == -1) @@ -680,6 +687,7 @@ logger(LOG_ERR, "connect: %s", strerror(errno)); retval = ABORT; } +#endif logger(LOG_DEBUG, "Creating new socket: %s:%d", sockaddr_print_addr(&to, addr_str, sizeof(addr_str)), sockaddr_get_port(&to)); diff -u atftp-0.7.dfsg/debian/changelog atftp-0.7.dfsg/debian/changelog --- atftp-0.7.dfsg/debian/changelog +++ atftp-0.7.dfsg/debian/changelog @@ -1,3 +1,26 @@ +atftp (0.7.dfsg-9.3~squeeze1) stable; urgency=low + + * Non-maintainer upload. + * Upload to stable to address #598474 and #609813 + + -- tony mancill <tmancill@debian.org> Sun, 06 Feb 2011 10:16:47 -0800 + +atftp (0.7.dfsg-9.3) unstable; urgency=low + + * Non-maintainer upload. + * Apply patch listen on requested port when in daemon mode. + Thanks to Len Sorensen. (Closes: #609813) + + -- tony mancill <tmancill@debian.org> Wed, 12 Jan 2011 20:58:05 -0800 + +atftp (0.7.dfsg-9.2) unstable; urgency=low + + * Non-maintainer upload. + * Fixed use of sendto() over a connected datagram socket on FreeBSD + (closes: #598474). + + -- Giovanni Mascellani <gio@debian.org> Mon, 04 Oct 2010 16:46:32 +0200 + atftp (0.7.dfsg-9.1) unstable; urgency=low * Non-maintainer upload.
Attachment:
signature.asc
Description: OpenPGP digital signature