Re: Please unblock blcr
On 7 October 2010 16:38, Julien Cristau <jcristau@debian.org> wrote:
> On Thu, Oct 7, 2010 at 16:34:03 +0100, Alan Woodland wrote:
>
>> On 6 October 2010 22:41, Julien Cristau <jcristau@debian.org> wrote:
>> > +- CR_LIBARCH=$CR_ARCH32
>> > ++ CR_LIBARCH=${CR_LIBARCH32:$CR_ARCH32}
>> >
>> > What is that supposed to do?
>>
>> This makes it so that if CR_LIBARCH32 has been set then that will be
>> used, otherwise CR_ARCH32 will be used. CR_LIBARCH32 is used to work
>> around a problem where CR_ARCH32 was being set to i686 instead of i386
>> when in a chroot on amd64. The problem with the simple solution of
>> just changing CR_ARCH32 is that it makes building the 32bit library on
>> amd64 fail.
>>
> Pretty sure that's not what it actually does, and you wanted
> CR_LIBARCH=${CR_LIBARCH32:-$CR_ARCH32}
> instead.
>
Ah yes, well spotted. Looks like a typo on my part and I didn't have
access to PPC64/SPARC64 machines when I was testing.
I'll fix this and upload again then.
Sorry,
Alan
Reply to: