Re: Please unblock blcr
On 6 October 2010 22:41, Julien Cristau <jcristau@debian.org> wrote:
> On Mon, Oct 4, 2010 at 17:00:56 +0100, Alan Woodland wrote:
>
>> Hi,
>>
>> BLCR 0.8.2-14 contains a number of changes which I think would be strong
>> candidates to see in Squeeze. These are:
>>
>> - Fix an FTBFS (slightly obscure, but important still) #597601
>> - Drop dependency_libs from .la files (Release goal)
>> - Add support for more recent kernels (including some 2.6.32 ones) #573112
>>
>> 0.8.2-14, which implements these changes makes no major changes over
>> 0.8.2-13 which is currently in Squeeze. There are no breakages or
>> changes introduced in libcr0. Therefore please consider unblocking this
>> in light of the included fixes.
>>
> +- CR_LIBARCH=$CR_ARCH32
> ++ CR_LIBARCH=${CR_LIBARCH32:$CR_ARCH32}
>
> What is that supposed to do?
This makes it so that if CR_LIBARCH32 has been set then that will be
used, otherwise CR_ARCH32 will be used. CR_LIBARCH32 is used to work
around a problem where CR_ARCH32 was being set to i686 instead of i386
when in a chroot on amd64. The problem with the simple solution of
just changing CR_ARCH32 is that it makes building the 32bit library on
amd64 fail.
I discussed this patch with the upstream author:
https://hpcrdm.lbl.gov/pipermail/checkpoint/2010-September/000086.html
Thanks,
Alan
Reply to: